From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!.POSTED!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Support ~N in SRFI-19 string->date Date: Tue, 11 Dec 2018 20:53:17 -0500 Message-ID: <87r2en8q8n.fsf@netris.org> References: <99C8A8EB-D4F9-4B5B-BD3B-5C45E4545720@bluewin.ch> NNTP-Posting-Host: blaine.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: blaine.gmane.org 1544579562 13246 195.159.176.226 (12 Dec 2018 01:52:42 GMT) X-Complaints-To: usenet@blaine.gmane.org NNTP-Posting-Date: Wed, 12 Dec 2018 01:52:42 +0000 (UTC) User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) Cc: guile-devel To: Daniel Llorens Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Dec 12 02:52:38 2018 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by blaine.gmane.org with esmtp (Exim 4.84_2) (envelope-from ) id 1gWthV-0003KR-O0 for guile-devel@m.gmane.org; Wed, 12 Dec 2018 02:52:37 +0100 Original-Received: from localhost ([::1]:42270 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWtjc-0007bv-BA for guile-devel@m.gmane.org; Tue, 11 Dec 2018 20:54:48 -0500 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:54572) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gWtjL-0007bq-VY for guile-devel@gnu.org; Tue, 11 Dec 2018 20:54:32 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gWtjH-0006Bu-2K for guile-devel@gnu.org; Tue, 11 Dec 2018 20:54:31 -0500 Original-Received: from world.peace.net ([64.112.178.59]:55646) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1gWtjG-00069p-S4 for guile-devel@gnu.org; Tue, 11 Dec 2018 20:54:26 -0500 Original-Received: from mhw by world.peace.net with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.89) (envelope-from ) id 1gWtjA-0006eC-3x; Tue, 11 Dec 2018 20:54:20 -0500 In-Reply-To: <99C8A8EB-D4F9-4B5B-BD3B-5C45E4545720@bluewin.ch> (Daniel Llorens's message of "Tue, 11 Dec 2018 19:28:55 +0100") X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 64.112.178.59 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.org gmane.lisp.guile.devel:19776 Archived-At: Hi Daniel, Daniel Llorens writes: > The previous patch had a broken test. New attempt, tested on stable-2.2. The revised tests are still broken. > diff --git a/test-suite/tests/srfi-19.test b/test-suite/tests/srfi-19.test > index 4d79f1043..256ff74a0 100644 > --- a/test-suite/tests/srfi-19.test > +++ b/test-suite/tests/srfi-19.test > @@ -176,6 +176,16 @@ incomplete numerical tower implementation.)" > (equal? "Sun Jun 05 18:33:00+0200 2005" > (date->string date)))) > > + (pass-if "string->date understands nanoseconds (1)" > + (time=? (date->time-utc (string->date "2018-12-10 10:53:24.189" > + "~Y-~m-~d ~H:~M:~S.~N")) > + (date->time-utc (make-date 189000000 24 53 10 10 12 2018 3600)))) > + > + (pass-if "string->date understands nanoseconds (2)" > + (time=? (date->time-utc (string->date "2018-12-10 10:53:24.189654321" > + "~Y-~m-~d ~H:~M:~S.~N")) > + (date->time-utc (make-date 189654321 24 53 10 10 12 2018 3600)))) > + > (pass-if "date->string pads small nanoseconds values correctly" > (let* ((date (make-date 99999999 5 34 12 26 3 2017 0))) > (equal? "099999999" The instances of '3600' above, given as the last argument to 'make-date', enable the tests to succeed in your time zone (+0100). They fail in every other time zone. Can you look into it and apply an appropriate fix? Thanks, Mark