unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
* [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon.
@ 2024-02-29 21:23 Denis 'GNUtoo' Carikli
  2024-03-06 18:42 ` Rob Browning
  0 siblings, 1 reply; 11+ messages in thread
From: Denis 'GNUtoo' Carikli @ 2024-02-29 21:23 UTC (permalink / raw)
  To: guile-devel; +Cc: Denis 'GNUtoo' Carikli

* module/srfi/srfi-19.scm (zone-reader): handle a colon in the zone.

* test-suite/tests/srfi-19.test (SRFI date/time library test): Add test.

Signed-off-by: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
---
 module/srfi/srfi-19.scm       | 5 +++++
 test-suite/tests/srfi-19.test | 3 +++
 2 files changed, 8 insertions(+)

diff --git a/module/srfi/srfi-19.scm b/module/srfi/srfi-19.scm
index 570f933ca..23d115926 100644
--- a/module/srfi/srfi-19.scm
+++ b/module/srfi/srfi-19.scm
@@ -1271,6 +1271,11 @@
               (if (eof-object? ch)
                   (time-error 'string->date 'bad-date-template-string
                               (list "Invalid time zone number" ch)))
+              (if (char=? ch #\:)
+                  (set! ch (read-char port))
+                  (if (eof-object? ch)
+                      (time-error 'string->date 'bad-date-template-string
+                                  (list "Invalid time zone number" ch))))
               (set! offset (+ offset (* (char->int ch)
                                         10 60))))
             (let ((ch (read-char port)))
diff --git a/test-suite/tests/srfi-19.test b/test-suite/tests/srfi-19.test
index 1d56214e4..55eb82320 100644
--- a/test-suite/tests/srfi-19.test
+++ b/test-suite/tests/srfi-19.test
@@ -120,6 +120,9 @@ incomplete numerical tower implementation.)"
   (pass-if "string->date works"
 	   (begin (string->date "2001-06-01@14:00" "~Y-~m-~d@~H:~M")
 		  #t))
+  (pass-if "string->date accepts ISO 8601 zones with a colon"
+	   (begin (string->date "2024-12-31T23:59:59+01:00" "~Y-~m-~dT~H:~M:~S~z")
+		  #t))
   ;; check for code paths where reals were passed to quotient, which
   ;; doesn't work in Guile (and is unspecified in R5RS)
   (test-time->date time-utc->date date->time-utc)

base-commit: 9e0f03c5fd36764827c8bb03887f14640c883b70
-- 
2.41.0




^ permalink raw reply related	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2024-04-13 19:44 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-02-29 21:23 [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon Denis 'GNUtoo' Carikli
2024-03-06 18:42 ` Rob Browning
2024-03-06 18:58   ` Rob Browning
2024-03-11 18:25   ` Denis 'GNUtoo' Carikli
2024-03-19 14:26     ` Denis 'GNUtoo' Carikli
2024-03-19 20:18     ` [PATCH v2] " Denis 'GNUtoo' Carikli
2024-03-20  0:21     ` [PATCH v1] " Rob Browning
2024-04-05 22:03       ` Rob Browning
2024-04-12 15:19         ` Denis 'GNUtoo' Carikli
2024-04-13 19:44           ` Rob Browning
2024-04-12 15:19       ` Denis 'GNUtoo' Carikli

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).