unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Rob Browning <rlb@defaultvalue.org>
To: Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon.
Date: Tue, 19 Mar 2024 19:21:19 -0500	[thread overview]
Message-ID: <87r0g57ny8.fsf@trouble.defaultvalue.org> (raw)
In-Reply-To: <20240311192508.5b974e64@trisquel64>

Denis 'GNUtoo' Carikli <GNUtoo@cyberdimension.org> writes:

> Would something like that be OK instead?:

Not sure I understand the question.  Were you asking if that'd be OK
elsewhere in the function too?

> However here (char=? ch #\:) can fail if ch is an eof-object.

Apologies for the delay, and good point.  I should have used eqv? rather
than char=?, i.e.

             (let ((ch (read-char port)))
               (when (eqv? ch #\:)
                   (set! ch (read-char port))
               (if (eof-object? ch)
                   (time-error 'string->date 'bad-date-template-string
                               (list "Invalid time zone number" ch)))
               (set! ...))

-- 
Rob Browning
rlb @defaultvalue.org and @debian.org
GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A
GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4



  parent reply	other threads:[~2024-03-20  0:21 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-02-29 21:23 [PATCH v1] SRFI-19: Add support for ISO 8601 zones with a colon Denis 'GNUtoo' Carikli
2024-03-06 18:42 ` Rob Browning
2024-03-06 18:58   ` Rob Browning
2024-03-11 18:25   ` Denis 'GNUtoo' Carikli
2024-03-19 14:26     ` Denis 'GNUtoo' Carikli
2024-03-19 20:18     ` [PATCH v2] " Denis 'GNUtoo' Carikli
2024-03-20  0:21     ` Rob Browning [this message]
2024-04-05 22:03       ` [PATCH v1] " Rob Browning
2024-04-12 15:19         ` Denis 'GNUtoo' Carikli
2024-04-13 19:44           ` Rob Browning
2024-04-12 15:19       ` Denis 'GNUtoo' Carikli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87r0g57ny8.fsf@trouble.defaultvalue.org \
    --to=rlb@defaultvalue.org \
    --cc=GNUtoo@cyberdimension.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).