From: Marius Vollmer <mvo@zagadka.de>
Cc: guile-user@gnu.org, guile-devel@gnu.org
Subject: Re: Guile 1.7.1 has been released.
Date: Tue, 21 Sep 2004 00:53:33 +0200 [thread overview]
Message-ID: <87pt4gv9g2.fsf@zagadka.ping.de> (raw)
In-Reply-To: <193B2882-F99D-11D8-A510-000D93673682@gmx.net> (Andreas Vögele's message of "Sun, 29 Aug 2004 11:23:33 +0200")
Andreas Vögele <voegelas@gmx.net> writes:
> I've attached a patch that replaces the remaining occurrences of int
> in srfi-13.c with size_t. In addition to these replacements, the
> function string_reverse_x() makes sure that the variable cend is only
> decremented if it's value is greater than zero.
Thanks, applied!
> One thing that I noted is that the variable cfrom in scm_xsubstring()
> and the variable csfrom in scm_string_xcopy_x() are of type size_t but
> that they are checked for negative values:
Yes, I changed them to be ints. The 'extended' indices can be
negative. Of course, the could also be bignums...
> BTW, do you prefer included or attached patches?
Either way is fine with me. For attached patches, using text/plain or
text/x-patch as the content-type makes it simpler to view it.
Also, and more importantly, inculding a ChangeLog entry is very
helpful.
--
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3 331E FAF8 226A D5D4 E405
_______________________________________________
Guile-user mailing list
Guile-user@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-user
prev parent reply other threads:[~2004-09-20 22:53 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2004-08-26 23:02 Guile 1.7.1 has been released Marius Vollmer
2004-08-27 22:57 ` Jonathan Bartlett
2004-08-28 21:35 ` Michael Tuexen
2004-08-29 9:23 ` Andreas Vögele
2004-09-20 22:53 ` Marius Vollmer [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pt4gv9g2.fsf@zagadka.ping.de \
--to=mvo@zagadka.de \
--cc=guile-devel@gnu.org \
--cc=guile-user@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).