From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: Optimization & factorization of =?utf-8?b?4oCYd3JpdGXigJk=?= Date: Wed, 15 Sep 2010 23:35:44 +0200 Message-ID: <87pqwed70v.fsf@gnu.org> References: <877hiowglj.fsf@gnu.org> <455480.11700.qm@web37907.mail.mud.yahoo.com> <87r5gwrvfn.fsf@gnu.org> <227537.62931.qm@web37907.mail.mud.yahoo.com> <87sk1bgrpe.fsf@gnu.org> <257144.86099.qm@web37904.mail.mud.yahoo.com> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1284586578 17267 80.91.229.12 (15 Sep 2010 21:36:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 15 Sep 2010 21:36:18 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Sep 15 23:36:17 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OvzeC-0004bM-AM for guile-devel@m.gmane.org; Wed, 15 Sep 2010 23:36:08 +0200 Original-Received: from localhost ([127.0.0.1]:43158 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OvzeB-0004pC-JT for guile-devel@m.gmane.org; Wed, 15 Sep 2010 17:36:07 -0400 Original-Received: from [140.186.70.92] (port=50072 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1Ovze2-0004no-KU for guile-devel@gnu.org; Wed, 15 Sep 2010 17:35:59 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1Ovze1-00089S-GE for guile-devel@gnu.org; Wed, 15 Sep 2010 17:35:58 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:43223) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1Ovze1-00089D-Av for guile-devel@gnu.org; Wed, 15 Sep 2010 17:35:57 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1Ovzdw-0004Qk-Kt for guile-devel@gnu.org; Wed, 15 Sep 2010 23:35:52 +0200 Original-Received: from yoda.fdn.fr ([80.67.169.18]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 15 Sep 2010 23:35:52 +0200 Original-Received: from ludo by yoda.fdn.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Wed, 15 Sep 2010 23:35:52 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 29 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: yoda.fdn.fr X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 29 Fructidor an 218 de la =?iso-8859-1?Q?R=E9volutio?= =?iso-8859-1?Q?n?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) Cancel-Lock: sha1:JttIwn68NxSIeWU6i+L+MdRhVy0= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:10920 Archived-At: Hi, Mike Gran writes: >> > But I tried it just now on HEAD, and it triggered a 'glibc detected >> > corrupteddouble-linked list' error. Curious. >> >> Hmm indeed. Can you come up with a reduced test case and perhaps a >> backtrace or something? >> > > in scm_i_unistring_escapes_to_r6rs_escapes(), you can have a write > off the end of a string when the buffer passed into the function contains > only 4-digit hex unistring hex escapes, such as "\u1100". The > R6RS-escaped string will be longer "\x1100;" causing the memcpy at the > end of the function to write off then end of the string. Indeed, good catch! I think commit f1ee6d54d219056c62d87a8e4a6b199162c946e8 hackily fixes it. The whole thing is hackish though: the conversion is inelegant, and it assumes that BUF is in an ASCII-compatible encoding. I think the right way would be to have libunistring allow us to specify what we want escapes to look like. Thanks, Ludo’.