unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: [PATCH 4/4] Add implementation of "transcoded ports"
Date: Wed, 24 Nov 2010 23:29:23 +0100	[thread overview]
Message-ID: <87pqtu5pa4.fsf@gnu.org> (raw)
In-Reply-To: 1290377874-13808-4-git-send-email-a.rottmann@gmx.at

Hello!

I pushed your patches, thanks!

Now, I’m slightly worried because now (rnrs io ports) /looks/ complete
but isn’t quite complete.  :-)

For instance,

  - ‘binary-port?’ always returns #t.

  - Transcoder EOL styles are silently ignored.

  - Not all the transcoder error handling modes are supported.

  - Decoding errors are thrown as native Guile exceptions, instead of
    R6RS conditions.

So I think “we” (i.e., you ;-)) should either implement the missing
stuff, or raise an exception, or print a warning when the caller asks
for something that’s not implemented (e.g., EOL style != native), or
document the current shortcomings.

What do you think?

Thanks,
Ludo’.




  reply	other threads:[~2010-11-24 22:29 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-11-15 21:45 Some work on the R6RS I/O libraries Andreas Rottmann
2010-11-19 23:59 ` Ludovic Courtès
2010-11-20 17:40   ` [PATCH 1/4] Fix missing port-table locking and bytevector output port segfault Andreas Rottmann
2010-11-20 22:43     ` Ludovic Courtès
2010-11-20 17:40   ` [PATCH 2/4] Add implementation of "transcoded ports" Andreas Rottmann
2010-11-20 22:52     ` Ludovic Courtès
2010-11-21 22:07       ` Andreas Rottmann
2010-11-21 22:17         ` [PATCH 1/4] Turn `(rnrs io ports)' into an R6RS library Andreas Rottmann
2010-11-21 22:17         ` [PATCH 2/4] Reorganize the R6RS I/O condition types Andreas Rottmann
2010-11-21 22:17         ` [PATCH 3/4] Work towards a more complete implementation of `(rnrs io ports)' Andreas Rottmann
2010-11-23 21:13           ` Ludovic Courtès
2010-11-23 23:44             ` Andreas Rottmann
2010-11-24 20:24               ` Ludovic Courtès
2010-11-21 22:17         ` [PATCH 4/4] Add implementation of "transcoded ports" Andreas Rottmann
2010-11-24 22:29           ` Ludovic Courtès [this message]
2010-11-25  0:08             ` Andreas Rottmann
2010-11-25 21:15               ` Ludovic Courtès
2010-11-20 17:40   ` [PATCH 3/4] Reorganize the R6RS I/O condition types Andreas Rottmann
2010-11-20 17:40   ` [PATCH 4/4] Work towards a more complete implementation of `(rnrs io ports)' Andreas Rottmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87pqtu5pa4.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).