From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: Signal thread Date: Mon, 27 Jun 2011 22:44:53 +0200 Message-ID: <87pqlzt35m.fsf@pobox.com> References: <87boxjuuwh.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: dough.gmane.org 1309211391 1730 80.91.229.12 (27 Jun 2011 21:49:51 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Mon, 27 Jun 2011 21:49:51 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Jun 27 23:49:43 2011 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([140.186.70.17]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1QbJgd-0004mu-0n for guile-devel@m.gmane.org; Mon, 27 Jun 2011 23:49:43 +0200 Original-Received: from localhost ([::1]:58063 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbJgb-0004Ho-P8 for guile-devel@m.gmane.org; Mon, 27 Jun 2011 17:49:42 -0400 Original-Received: from eggs.gnu.org ([140.186.70.92]:60355) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbIg0-0004xw-I9 for guile-devel@gnu.org; Mon, 27 Jun 2011 16:45:02 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1QbIfy-0002lN-D1 for guile-devel@gnu.org; Mon, 27 Jun 2011 16:45:00 -0400 Original-Received: from a-pb-sasl-sd.pobox.com ([64.74.157.62]:41657 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1QbIfy-0002lH-1U; Mon, 27 Jun 2011 16:44:58 -0400 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 1D62D587F; Mon, 27 Jun 2011 16:47:10 -0400 (EDT) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; s=sasl; bh=DmUAXA1PuWuu zH8jY8ONKeE7ruk=; b=FHkRg3QtQNKDOgifjKdCZVlbSShJRj6T+Q1uuXvR8mwJ O2fdBYdbS+41ozU5wZS5VXuTwECxQouynRr4s+rZNfcY1EnHwDHbH/CcLIvnqLgz xzvor1b7NsrQcGzzzBmCIEyd9xGUusgDomSgN/L9myn/dGbs77ilxW8UIB/aCTE= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type:content-transfer-encoding; q=dns; s=sasl; b=rLOYbf 8gF3ITRC0zhXVoFsz+K95qes32h3CxhCQRyvcVU5g8V0h9PbZXKJrGSB0+ezdi8T Uzu/E8CMF7hYsUK4jkbmHG5SiJJWstn7tkWx+OibaX4NKz9CHKDFmheSxbxRWD+V rBk5DCgeC6OOx2X/9L/qVW7bWD1Av/ZBLjOD8= Original-Received: from a-pb-sasl-sd.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTP id 152E4587A; Mon, 27 Jun 2011 16:47:10 -0400 (EDT) Original-Received: from badger (unknown [90.164.198.39]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-sd.pobox.com (Postfix) with ESMTPSA id 3E4FE5879; Mon, 27 Jun 2011 16:47:09 -0400 (EDT) In-Reply-To: <87boxjuuwh.fsf@gnu.org> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?= =?utf-8?Q?s?= message of "Mon, 27 Jun 2011 18:00:14 +0200") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.3 (gnu/linux) X-Pobox-Relay-ID: A061CD5E-A0FE-11E0-896E-5875C023C68D-02397024!a-pb-sasl-sd.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 (beta) X-Received-From: 64.74.157.62 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:12593 Archived-At: Hello guild-comrade Court=C3=A8s! On Mon 27 Jun 2011 18:00, ludo@gnu.org (Ludovic Court=C3=A8s) writes: > "Andy Wingo" skribis: > >> commit 3b971a59b55586a236c3621a55515d9272ee5c80 >> Author: Andy Wingo >> Date: Thu Jun 23 11:24:16 2011 +0200 >> >> don't spawn the signal delivery thread in a thread-exit handler >>=20=20=20=20=20 >> * libguile/threads.c (do_thread_exit): Remove needless spawn of the >> signal delivery thread. > > Out of curiosity, what=E2=80=99s the rationale? Should it be done in sta= ble-2.0 > as well? Out of curiosity, I looked :) The commit that added the spawning code was 2e77f7202b11ad0003831fcff94ec7db80cca015 from you, which unfortunately has no log. Actually, let's take this opportunity to have a moment of silence for Arch. Ah. I remember those days and am quite happy to live in the age of git :-) Anyway, spawning a thread just to shut it down didn't make any sense to me. I looked and looked and couldn't justify it. It seems that the only case that might matter, closing the signal pipe, worked just fine whether the thread had been spawned or not. So I removed that code. Should it apply to 2.0? Perhaps, but I didn't want it to block 2.0.2. > As a side note, why does this area have to change so often? :-) I understand the frustration :) Threads are hard, signals are hard, GC and threads and signals is hard. But I do hope it's getting better. Cheers, Andy --=20 http://wingolog.org/