Re: Signal thread

[Andy Wingo <wingo@pobox.com>]

Hello guild-comrade Courtès!

On Mon 27 Jun 2011 18:00, ludo@gnu.org (Ludovic Courtès) writes:

> "Andy Wingo" <wingo@pobox.com> skribis:
>
>> commit 3b971a59b55586a236c3621a55515d9272ee5c80
>> Author: Andy Wingo <wingo@pobox.com>
>> Date:   Thu Jun 23 11:24:16 2011 +0200
>>
>>     don't spawn the signal delivery thread in a thread-exit handler
>>     
>>     * libguile/threads.c (do_thread_exit): Remove needless spawn of the
>>       signal delivery thread.
>
> Out of curiosity, what’s the rationale?  Should it be done in stable-2.0
> as well?

Out of curiosity, I looked :)  The commit that added the spawning code
was 2e77f7202b11ad0003831fcff94ec7db80cca015 from you, which
unfortunately has no log.  Actually, let's take this opportunity to have
a moment of silence for Arch.





Ah.  I remember those days and am quite happy to live in the age of git
:-)

Anyway, spawning a thread just to shut it down didn't make any sense to
me.  I looked and looked and couldn't justify it.  It seems that the
only case that might matter, closing the signal pipe, worked just fine
whether the thread had been spawned or not.  So I removed that code.

Should it apply to 2.0?  Perhaps, but I didn't want it to block 2.0.2.

> As a side note, why does this area have to change so often?  :-)

I understand the frustration :)  Threads are hard, signals are hard, GC
and threads and signals is hard.  But I do hope it's getting better.

Cheers,

Andy
-- 
http://wingolog.org/