From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: [PATCH] Futures: Avoid creating the worker pool more than once
Date: Sat, 17 Nov 2012 00:15:07 +0100 [thread overview]
Message-ID: <87pq3dw35w.fsf@gnu.org> (raw)
In-Reply-To: 87r4o58r0f.fsf@tines.lan
Hi Mark,
Mark H Weaver <mhw@netris.org> skribis:
> From b0d936a348b916e73e9071abeb7baae3d7c126d3 Mon Sep 17 00:00:00 2001
> From: Mark H Weaver <mhw@netris.org>
> Date: Wed, 7 Nov 2012 08:39:42 -0500
> Subject: [PATCH] Futures: Avoid creating the worker pool more than once.
>
> * module/ice-9/futures.scm (%create-workers!): Use 'with-mutex' in case
> an exception is thrown. Within the critical section, check to make
> sure the worker pool hasn't already been created by another thread.
> ---
> module/ice-9/futures.scm | 24 +++++++++++++++---------
> 1 file changed, 15 insertions(+), 9 deletions(-)
>
>
> diff --git a/module/ice-9/futures.scm b/module/ice-9/futures.scm
> index 0f64b5c..7fbccf6 100644
> --- a/module/ice-9/futures.scm
> +++ b/module/ice-9/futures.scm
> @@ -19,6 +19,7 @@
> (define-module (ice-9 futures)
> #:use-module (srfi srfi-1)
> #:use-module (srfi srfi-9)
> + #:use-module (ice-9 threads)
> #:use-module (ice-9 q)
> #:export (future make-future future? touch))
I just realized that this patch introduces a circular dependency between
the two modules.
Can you think of a way to avoid it?
Thanks,
Ludo’.
next prev parent reply other threads:[~2012-11-16 23:15 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-06 23:07 [PATCH] Futures: Avoid creating the worker pool more than once Mark H Weaver
2012-11-07 13:46 ` Mark H Weaver
2012-11-07 14:14 ` Daniel Hartwig
2012-11-16 23:15 ` Ludovic Courtès [this message]
2012-11-30 19:01 ` Mark H Weaver
2012-11-30 20:14 ` Ludovic Courtès
2012-11-08 19:11 ` Ludovic Courtès
2012-11-10 3:13 ` Mark H Weaver
2012-11-10 13:53 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87pq3dw35w.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).