From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Neil Jerram Newsgroups: gmane.lisp.guile.devel Subject: Re: Inlining `scm_getc ()' and friends Date: Tue, 15 Apr 2008 23:14:59 +0100 Message-ID: <87od8a4vfg.fsf@ossau.uklinux.net> References: <87iqyk9z9z.fsf@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1208297744 9405 80.91.229.12 (15 Apr 2008 22:15:44 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Tue, 15 Apr 2008 22:15:44 +0000 (UTC) Cc: guile-devel@gnu.org To: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Apr 16 00:16:04 2008 connect(): Connection refused Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JltRR-0000UE-1m for guile-devel@m.gmane.org; Wed, 16 Apr 2008 00:15:53 +0200 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JltQm-0004iD-7p for guile-devel@m.gmane.org; Tue, 15 Apr 2008 18:15:12 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JltQk-0004i8-RB for guile-devel@gnu.org; Tue, 15 Apr 2008 18:15:10 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JltQj-0004hw-Ps for guile-devel@gnu.org; Tue, 15 Apr 2008 18:15:10 -0400 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JltQj-0004ht-K8 for guile-devel@gnu.org; Tue, 15 Apr 2008 18:15:09 -0400 Original-Received: from mail3.uklinux.net ([80.84.72.33]) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1JltQd-0007ZY-N2; Tue, 15 Apr 2008 18:15:03 -0400 Original-Received: from arudy (host86-145-183-175.range86-145.btcentralplus.com [86.145.183.175]) by mail3.uklinux.net (Postfix) with ESMTP id 8B4F21F661F; Tue, 15 Apr 2008 23:15:00 +0100 (BST) Original-Received: from laruns (laruns [192.168.0.10]) by arudy (Postfix) with ESMTP id 1B5FE3800D; Tue, 15 Apr 2008 23:15:00 +0100 (BST) In-Reply-To: <87iqyk9z9z.fsf@gnu.org> (Ludovic =?iso-8859-1?Q?Court=E8s's?= message of "Mon, 14 Apr 2008 18:28:24 +0200") User-Agent: Gnus/5.110006 (No Gnus v0.6) Emacs/21.4 (gnu/linux) X-detected-kernel: by monty-python.gnu.org: Linux 2.4-2.6 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:7160 Archived-At: ludo@gnu.org (Ludovic Court=E8s) writes: > Hello, > > Small I/O functions like `scm_getc ()' deserve to be inlined. For > instance, Andy measured it some time ago: > > http://thread.gmane.org/gmane.lisp.guile.devel/6639 > > I'm planning to apply the attached patch to both `master' and 1.8. > > To get an idea of its benefit, I run the attached "benchmark" (inspired > from that in Guile-Reader) that does a lot of `read'. On my 1.2 GHz > Intel Centrino, the inlining yields a 15% run-time improvement for that > test. > > OK to apply? Yes, all looks good to me. Would it also make sense to commit the benchmark? We already have a "benchmark-suite" directory. Neil