unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Neil Jerram <neil@ossau.uklinux.net>
To: ludo@gnu.org (Ludovic Courtès)
Cc: guile-devel@gnu.org
Subject: Re: Inlining `scm_getc ()' and friends
Date: Tue, 15 Apr 2008 23:14:59 +0100	[thread overview]
Message-ID: <87od8a4vfg.fsf@ossau.uklinux.net> (raw)
In-Reply-To: <87iqyk9z9z.fsf@gnu.org> (Ludovic Courtès's message of "Mon, 14 Apr 2008 18:28:24 +0200")

ludo@gnu.org (Ludovic Courtès) writes:

> Hello,
>
> Small I/O functions like `scm_getc ()' deserve to be inlined.  For
> instance, Andy measured it some time ago:
>
>   http://thread.gmane.org/gmane.lisp.guile.devel/6639
>
> I'm planning to apply the attached patch to both `master' and 1.8.
>
> To get an idea of its benefit, I run the attached "benchmark" (inspired
> from that in Guile-Reader) that does a lot of `read'.  On my 1.2 GHz
> Intel Centrino, the inlining yields a 15% run-time improvement for that
> test.
>
> OK to apply?

Yes, all looks good to me.

Would it also make sense to commit the benchmark?  We already have a
"benchmark-suite" directory.

     Neil





  reply	other threads:[~2008-04-15 22:14 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-04-14 16:28 Inlining `scm_getc ()' and friends Ludovic Courtès
2008-04-15 22:14 ` Neil Jerram [this message]
2008-04-16  8:14   ` Ludovic Courtès
2008-04-16 20:34     ` Neil Jerram
2008-04-17  8:32       ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87od8a4vfg.fsf@ossau.uklinux.net \
    --to=neil@ossau.uklinux.net \
    --cc=guile-devel@gnu.org \
    --cc=ludo@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).