unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: [PATCH] Revise GC asserts.
Date: Thu, 11 Sep 2008 12:28:19 +0200	[thread overview]
Message-ID: <87od2v7z98.fsf@gnu.org> (raw)
In-Reply-To: gaadgi$tps$1@ger.gmane.org

Hello,

Han-Wen Nienhuys <hanwen@xs4all.nl> writes:

> Ludovic Courtès escreveu:
>>> * libguile/gc.c (scm_i_gc): Change assert into deprecation warning.
>> 
>> Why?  It's not a deprecation but really an invariant, right?
>
> Yes, but it probably does not warrant crashing the program; memory 
> allocation sizes will just be a bit off as a result.

While the thing is under development, it probably makes sense to have an
`assert ()'.  Hitting these assertions wouldn't be a problem if there
was a separate GC development branch.  In the meantime, `printf ()'
seems better suited than `scm_c_issue_deprecation_warning ()'.

> Let's just remove the variable, since scm_i_last_marked_cell_count is a
> more exact name.

OK.

Thanks,
Ludo'.





  reply	other threads:[~2008-09-11 10:28 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-09-10  3:14 [PATCH] Revise GC asserts Han-Wen Nienhuys
2008-09-10  7:32 ` Ludovic Courtès
2008-09-11  6:21   ` Han-Wen Nienhuys
2008-09-11 10:28     ` Ludovic Courtès [this message]
2008-09-11 15:14   ` Han-Wen Nienhuys
2008-09-11 18:38     ` Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87od2v7z98.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).