From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: =?utf-8?Q?Ludovic_Court=C3=A8s?= Newsgroups: gmane.lisp.guile.devel Subject: Re: bug#73605: [PATCH] Replace SRFI-64 with a new implementation. Date: Sun, 13 Oct 2024 22:09:36 +0200 Message-ID: <87o73nrchr.fsf@gnu.org> References: <20241002194105.24409-1-~@wolfsden.cz> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="36537"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Cc: 73605@debbugs.gnu.org, guile-devel@gnu.org, Andy Wingo , Rob Browning To: Tomas Volf <~@wolfsden.cz> Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Sun Oct 13 22:10:17 2024 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1t04uu-0009Kp-L5 for guile-devel@m.gmane-mx.org; Sun, 13 Oct 2024 22:10:16 +0200 Original-Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t04uU-0002h9-JO; Sun, 13 Oct 2024 16:09:50 -0400 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t04uS-0002gj-8v for guile-devel@gnu.org; Sun, 13 Oct 2024 16:09:48 -0400 Original-Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t04uQ-00055m-TC; Sun, 13 Oct 2024 16:09:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=OBVzCy+EpEgQOzuFazZV3O8vImKqQlbRZHKijDef+jQ=; b=O5cTYYSAanCvnEuPqX4e zD495jyp15TFVrNEwTdSn2SoWZ5UY9SwXSKAJQ7NAT2FknuSrJQwgNhl0nGLk4xdjyVN5zNXpVBpC vK7H87ZPAduKslu+T2+mebaXMvIyXhvRD8wfcgQ/JchTl2icZSzXWsR/jPPUACKiDBKtLMioailMF FRCsbs5l4Zl1cKjeMqftFSTGRhyv0JuW81ErjBo6dJ4sqfm9aQoB26GjsyVgyBqKvdg3dliW0fp+h GNz0MVU2oOGYFMmkc/b+CMgPPLYeGFUOWRLVI3fwXLTYMLE8vnwHBWxsPP9YZX5r/uUat+FF6yqE1 lEEHNRBFiSY0hA==; In-Reply-To: <20241002194105.24409-1-~@wolfsden.cz> (Tomas Volf's message of "Wed, 2 Oct 2024 21:27:59 +0200") X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Xref: news.gmane.io gmane.lisp.guile.devel:22730 Archived-At: Hi Tomas, Tomas Volf <~@wolfsden.cz> skribis: > The bundled (reference) implementation was of somewhat mixed quality and > it failed to follow standard in multiple places. This commit replaces > it with a new one, written from scratch to follow the standard as close > as possible. > > * module/srfi/srfi-64/testing.scm: Delete file. > * module/srfi/srfi-64.scm: Replace with new implementation. > * am/bootstrap.am (srfi/srfi-64.go): Remove extra dependencies. > (NOCOMP_SOURCES): Remove srfi/srfi-64/testing.scm. > * test-suite/tests/srfi-64-test.scm > ("8.6.1. Simple (form 1) test-apply") > ("8.6.2. Simple (form 2) test-apply"): Adjust tests to follow the > specification. Nice work! Andy, Rob: I=E2=80=99m willing to apply this patch as I think it=E2=80=99s = an improvement over the reference implementation that we currently have, and whose weaknesses Tomas described at length in . The fact that this new implementation was successfully tested with the test suite of Guix (probably the largest SRFI-64 user) is also reassuring to me. Everyone, please speak up if you object. If there are no objections within a week or so, I=E2=80=99d like to apply it. Thanks, Ludo=E2=80=99.