From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.lisp.guile.devel Subject: 1.6 debian bug #291240 bad polar number Date: Thu, 17 Feb 2005 11:30:16 +1100 Message-ID: <87mzu4c9k7.fsf@zip.com.au> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Trace: sea.gmane.org 1108600629 29303 80.91.229.2 (17 Feb 2005 00:37:09 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Thu, 17 Feb 2005 00:37:09 +0000 (UTC) Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Feb 17 01:37:09 2005 Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1D1Zf9-0007YY-Mm for guile-devel@m.gmane.org; Thu, 17 Feb 2005 01:37:00 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D1ZvC-0004Js-12 for guile-devel@m.gmane.org; Wed, 16 Feb 2005 19:53:34 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1D1ZuF-0003pd-OT for guile-devel@gnu.org; Wed, 16 Feb 2005 19:52:36 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1D1Zu4-0003n0-FN for guile-devel@gnu.org; Wed, 16 Feb 2005 19:52:26 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1D1Zu2-0003jL-JQ for guile-devel@gnu.org; Wed, 16 Feb 2005 19:52:22 -0500 Original-Received: from [61.8.0.85] (helo=mailout2.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.34) id 1D1ZYu-00084i-96 for guile-devel@gnu.org; Wed, 16 Feb 2005 19:30:32 -0500 Original-Received: from mailproxy2.pacific.net.au (mailproxy2.pacific.net.au [61.8.0.87]) by mailout2.pacific.net.au (8.12.3/8.12.3/Debian-7.1) with ESMTP id j1H0URHn029885 for ; Thu, 17 Feb 2005 11:30:27 +1100 Original-Received: from localhost (ppp251D.dyn.pacific.net.au [61.8.37.29]) by mailproxy2.pacific.net.au (8.12.3/8.12.3/Debian-7.1) with ESMTP id j1H0UPMp009300 for ; Thu, 17 Feb 2005 11:30:25 +1100 Original-Received: from gg by localhost with local (Exim 3.36 #1 (Debian)) id 1D1ZYf-0001wS-00; Thu, 17 Feb 2005 11:30:17 +1100 Original-To: guile-devel@gnu.org Mail-Copies-To: never User-Agent: Gnus/5.110003 (No Gnus v0.3) Emacs/21.3 (gnu/linux) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org X-MailScanner-To: guile-devel@m.gmane.org Xref: main.gmane.org gmane.lisp.guile.devel:4785 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:4785 --=-=-= A debian bug report notes for 1.6, (string->number "1@a") => seg fault Looks like the polar parsing code doesn't cope with #f coming back for the angle part. Does this change sound right? It seems to do the trick. * numbers.c (scm_istr2flo): Use SCM_INEXACTP not SCM_SLOPPY_INEXACTP, since value can be #f. --=-=-= Content-Disposition: attachment; filename=numbers.c.polar.diff --- numbers.c.~1.135.2.19.~ 2004-12-09 09:39:46.000000000 +1100 +++ numbers.c 2005-02-17 11:26:33.812403880 +1100 @@ -2691,7 +2691,7 @@ { /* polar input for complex number */ /* get a `real' for scm_angle */ second = scm_istr2flo (&str[i], (long) (len - i), radix); - if (!SCM_SLOPPY_INEXACTP (second)) + if (!SCM_INEXACTP (second)) return SCM_BOOL_F; /* not `real' */ if (SCM_SLOPPY_COMPLEXP (second)) return SCM_BOOL_F; /* not `real' */ --=-=-= Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel --=-=-=--