* 1.6 debian bug #291240 bad polar number
@ 2005-02-17 0:30 Kevin Ryde
2005-02-28 2:49 ` Marius Vollmer
0 siblings, 1 reply; 2+ messages in thread
From: Kevin Ryde @ 2005-02-17 0:30 UTC (permalink / raw)
[-- Attachment #1: Type: text/plain, Size: 331 bytes --]
A debian bug report notes for 1.6,
(string->number "1@a")
=> seg fault
Looks like the polar parsing code doesn't cope with #f coming back for
the angle part. Does this change sound right? It seems to do the
trick.
* numbers.c (scm_istr2flo): Use SCM_INEXACTP not SCM_SLOPPY_INEXACTP,
since value can be #f.
[-- Attachment #2: numbers.c.polar.diff --]
[-- Type: text/plain, Size: 463 bytes --]
--- numbers.c.~1.135.2.19.~ 2004-12-09 09:39:46.000000000 +1100
+++ numbers.c 2005-02-17 11:26:33.812403880 +1100
@@ -2691,7 +2691,7 @@
{ /* polar input for complex number */
/* get a `real' for scm_angle */
second = scm_istr2flo (&str[i], (long) (len - i), radix);
- if (!SCM_SLOPPY_INEXACTP (second))
+ if (!SCM_INEXACTP (second))
return SCM_BOOL_F; /* not `real' */
if (SCM_SLOPPY_COMPLEXP (second))
return SCM_BOOL_F; /* not `real' */
[-- Attachment #3: Type: text/plain, Size: 143 bytes --]
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: 1.6 debian bug #291240 bad polar number
2005-02-17 0:30 1.6 debian bug #291240 bad polar number Kevin Ryde
@ 2005-02-28 2:49 ` Marius Vollmer
0 siblings, 0 replies; 2+ messages in thread
From: Marius Vollmer @ 2005-02-28 2:49 UTC (permalink / raw)
Kevin Ryde <user42@zip.com.au> writes:
> Looks like the polar parsing code doesn't cope with #f coming back for
> the angle part. Does this change sound right? It seems to do the
> trick.
Yes, looks right to me!
--
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3 331E FAF8 226A D5D4 E405
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2005-02-28 2:49 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2005-02-17 0:30 1.6 debian bug #291240 bad polar number Kevin Ryde
2005-02-28 2:49 ` Marius Vollmer
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).