unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Kevin Ryde <user42@zip.com.au>
Subject: 1.6 debian bug #291240 bad polar number
Date: Thu, 17 Feb 2005 11:30:16 +1100	[thread overview]
Message-ID: <87mzu4c9k7.fsf@zip.com.au> (raw)

[-- Attachment #1: Type: text/plain, Size: 331 bytes --]

A debian bug report notes for 1.6,

	(string->number "1@a")
	=> seg fault

Looks like the polar parsing code doesn't cope with #f coming back for
the angle part.  Does this change sound right?  It seems to do the
trick.

        * numbers.c (scm_istr2flo): Use SCM_INEXACTP not SCM_SLOPPY_INEXACTP,
        since value can be #f.


[-- Attachment #2: numbers.c.polar.diff --]
[-- Type: text/plain, Size: 463 bytes --]

--- numbers.c.~1.135.2.19.~	2004-12-09 09:39:46.000000000 +1100
+++ numbers.c	2005-02-17 11:26:33.812403880 +1100
@@ -2691,7 +2691,7 @@
       {				/* polar input for complex number */
 	/* get a `real' for scm_angle */
 	second = scm_istr2flo (&str[i], (long) (len - i), radix);
-	if (!SCM_SLOPPY_INEXACTP (second))
+	if (!SCM_INEXACTP (second))
 	  return SCM_BOOL_F;	/* not `real' */
 	if (SCM_SLOPPY_COMPLEXP (second))
 	  return SCM_BOOL_F;	/* not `real' */

[-- Attachment #3: Type: text/plain, Size: 143 bytes --]

_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel

             reply	other threads:[~2005-02-17  0:30 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2005-02-17  0:30 Kevin Ryde [this message]
2005-02-28  2:49 ` 1.6 debian bug #291240 bad polar number Marius Vollmer

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mzu4c9k7.fsf@zip.com.au \
    --to=user42@zip.com.au \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).