unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: MinGW build fixes
Date: Sat, 27 Jun 2009 02:03:08 +0200	[thread overview]
Message-ID: <87my7uh7b7.fsf@gnu.org> (raw)
In-Reply-To: 87my7uk1kc.fsf@arudy.ossau.uklinux.net

Hello!

Neil Jerram <neil@ossau.uklinux.net> writes:

> - MinGW can't export/import struct variables from/to a DLL, so wrap
>   the ones needed by inline.h in exported/imported pointer variables.

[...]

> * libguile/gc.h (scm_i_freelist_ptr, scm_i_freelist2_ptr,
>   scm_i_master_freelist_ptr, scm_i_master_freelist2_ptr): New global
>   variable declarations.
>
> * libguile/inline.h (scm_cell): Use scm_i_freelist_ptr and
>   scm_i_master_freelist_ptr instead of scm_i_freelist and
>   scm_i_master_freelist.
>   (scm_double_cell): Use scm_i_freelist2_ptr and
>   scm_i_master_freelist2_ptr instead of scm_i_freelist2 and
>   scm_i_master_freelist2.
>
> * libguile/threads.c (scm_i_freelist_ptr, scm_i_freelist2_ptr): New
>   global variables.

[...]

>  SCM_API struct scm_t_cell_type_statistics scm_i_master_freelist;
> +SCM_API struct scm_t_cell_type_statistics *scm_i_master_freelist_ptr;
>  SCM_API struct scm_t_cell_type_statistics scm_i_master_freelist2;
> +SCM_API struct scm_t_cell_type_statistics *scm_i_master_freelist2_ptr;

I don't understand why this fixes anything, since the `_ptr' variables
are declared as `SCM_API' just like the non-`_ptr' variables.

Also, it adds an indirection, which may impact performance.

Other than that, I think this is good news!

Thanks,
Ludo'.





  reply	other threads:[~2009-06-27  0:03 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-26 23:38 MinGW build fixes Neil Jerram
2009-06-27  0:03 ` Ludovic Courtès [this message]
2009-06-27  9:29   ` Neil Jerram
  -- strict thread matches above, loose matches on Subject: below --
2009-06-27 10:22 carlo.bramix
2009-06-27 17:21 ` Neil Jerram

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87my7uh7b7.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).