From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Date: Thu, 28 Oct 2010 00:14:39 +0200 Message-ID: <87mxpzqo4w.fsf@gnu.org> References: <87d3qvo5i4.fsf@ossau.uklinux.net> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1288217710 15355 80.91.229.12 (27 Oct 2010 22:15:10 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Wed, 27 Oct 2010 22:15:10 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Oct 28 00:15:09 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1PBEGv-0005Yg-6v for guile-devel@m.gmane.org; Thu, 28 Oct 2010 00:15:05 +0200 Original-Received: from localhost ([127.0.0.1]:50039 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBEGu-0007eI-By for guile-devel@m.gmane.org; Wed, 27 Oct 2010 18:15:04 -0400 Original-Received: from [140.186.70.92] (port=40302 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1PBEGh-0007c2-B4 for guile-devel@gnu.org; Wed, 27 Oct 2010 18:14:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1PBEGg-0003A7-7D for guile-devel@gnu.org; Wed, 27 Oct 2010 18:14:51 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:36862) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1PBEGg-00039t-0S for guile-devel@gnu.org; Wed, 27 Oct 2010 18:14:50 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1PBEGe-0005Pq-L0 for guile-devel@gnu.org; Thu, 28 Oct 2010 00:14:48 +0200 Original-Received: from yoda.fdn.fr ([80.67.169.18]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 28 Oct 2010 00:14:48 +0200 Original-Received: from ludo by yoda.fdn.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Thu, 28 Oct 2010 00:14:48 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 24 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: yoda.fdn.fr X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 Brumaire an 219 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) Cancel-Lock: sha1:bBUfH5yXqQILZ2KrqRdCwFgXaEc= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:11080 Archived-At: Hi Neil, Neil Jerram writes: > I have a program that calls (read-elisp) in a loop, to read in a BBDB > file. When it gets to the end of the file, the next (read-elisp) throws > an error (wrong type arg, pair expected), and the attached patch makes > it return '*eoi* instead. > > Is that correct? ‘get-lexer/1’ can return '*eoi*, so yes, I think. > Is *eoi* better than # here? I don’t think so, since it’s the result returned by ‘read-elisp’, whose callers shouldn’t see '*eoi*. So I think ‘get-expression’ should return the EOF object when it encounters '*eoi*. Besides, you might want to check if it’s fixed in the elisp branch, who knows. :-) Thanks, Ludo’.