From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Mark H Weaver Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] In string-split, add support for character sets and predicates. Date: Tue, 09 Oct 2012 22:14:56 -0400 Message-ID: <87mwzvkr8f.fsf@tines.lan> References: <87sj9pm0oz.fsf@tines.lan> <874nm3mt92.fsf@tines.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1349835318 8829 80.91.229.3 (10 Oct 2012 02:15:18 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 10 Oct 2012 02:15:18 +0000 (UTC) Cc: guile-devel@gnu.org To: Daniel Hartwig Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Oct 10 04:15:25 2012 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1TLlpS-0005gl-W7 for guile-devel@m.gmane.org; Wed, 10 Oct 2012 04:15:23 +0200 Original-Received: from localhost ([::1]:60914 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLlpL-0006HG-V9 for guile-devel@m.gmane.org; Tue, 09 Oct 2012 22:15:15 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57126) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLlpJ-0006H0-F6 for guile-devel@gnu.org; Tue, 09 Oct 2012 22:15:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1TLlpI-00072M-Af for guile-devel@gnu.org; Tue, 09 Oct 2012 22:15:13 -0400 Original-Received: from world.peace.net ([96.39.62.75]:49867) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1TLlpI-00071F-5O for guile-devel@gnu.org; Tue, 09 Oct 2012 22:15:12 -0400 Original-Received: from 209-6-91-212.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com ([209.6.91.212] helo=tines.lan) by world.peace.net with esmtpsa (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.72) (envelope-from ) id 1TLlpA-0008ML-QM; Tue, 09 Oct 2012 22:15:04 -0400 In-Reply-To: (Daniel Hartwig's message of "Wed, 10 Oct 2012 09:37:43 +0800") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-Received-From: 96.39.62.75 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:14952 Archived-At: Daniel Hartwig writes: > On 10 October 2012 01:48, Mark H Weaver wrote: >> Please drop the unneeded curly braces above. > > Are guile's macros safe to always use that way? They should be. If they aren't, that's a bug IMO. > In libguile/__scm.h > the SCM_ASSERT definition is conditional on SCM_RECKLESS and appears > unsafe without the block. Looks safe to me. If SCM_RECKLESS is set, then 'SCM_ASSERT(...)' becomes the empty string, but the immediately following ';' remains and becomes a C null statement. Your latest patch looks good, but I just remembered one more thing: doc/ref/api-data.texi needs to be updated. Are you willing? :) Thanks! Mark