From: Mark H Weaver <mhw@netris.org>
To: Daniel Hartwig <mandyke@gmail.com>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] In string-split, add support for character sets and predicates.
Date: Tue, 09 Oct 2012 22:14:56 -0400 [thread overview]
Message-ID: <87mwzvkr8f.fsf@tines.lan> (raw)
In-Reply-To: <CAN3veRehch8jmPmgzar-UquEOFqemEZ+6bCN2Sz0TEGAemgmHQ@mail.gmail.com> (Daniel Hartwig's message of "Wed, 10 Oct 2012 09:37:43 +0800")
Daniel Hartwig <mandyke@gmail.com> writes:
> On 10 October 2012 01:48, Mark H Weaver <mhw@netris.org> wrote:
>> Please drop the unneeded curly braces above.
>
> Are guile's macros safe to always use that way?
They should be. If they aren't, that's a bug IMO.
> In libguile/__scm.h
> the SCM_ASSERT definition is conditional on SCM_RECKLESS and appears
> unsafe without the block.
Looks safe to me. If SCM_RECKLESS is set, then 'SCM_ASSERT(...)'
becomes the empty string, but the immediately following ';' remains
and becomes a C null statement.
Your latest patch looks good, but I just remembered one more thing:
doc/ref/api-data.texi needs to be updated.
Are you willing? :)
Thanks!
Mark
next prev parent reply other threads:[~2012-10-10 2:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 11:23 [PATCH] In string-split, add support for character sets and predicates Daniel Hartwig
2012-10-08 15:40 ` Mark H Weaver
2012-10-09 3:34 ` Daniel Hartwig
2012-10-09 17:48 ` Mark H Weaver
2012-10-10 1:37 ` Daniel Hartwig
2012-10-10 2:14 ` Mark H Weaver [this message]
2012-10-10 3:15 ` Daniel Hartwig
2012-10-10 3:25 ` Mark H Weaver
2012-10-10 3:28 ` Daniel Hartwig
2012-10-10 7:59 ` Mark H Weaver
2012-10-10 20:44 ` Ludovic Courtès
2012-10-12 6:38 ` Daniel Hartwig
2012-10-12 12:23 ` Mark H Weaver
2012-10-10 20:42 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mwzvkr8f.fsf@tines.lan \
--to=mhw@netris.org \
--cc=guile-devel@gnu.org \
--cc=mandyke@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).