From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Do not scan for coding declarations in open-file Date: Thu, 31 Jan 2013 11:00:44 +0100 Message-ID: <87mwvpwu2b.fsf@pobox.com> References: <87zk0dq6sb.fsf@tines.lan> <8738y2x04e.fsf@gnu.org> <87zk01v45b.fsf@pobox.com> <878v7ahrfz.fsf_-_@tines.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1359626458 30510 80.91.229.3 (31 Jan 2013 10:00:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Thu, 31 Jan 2013 10:00:58 +0000 (UTC) Cc: Ludovic =?utf-8?Q?Court=C3=A8s?= , guile-devel@gnu.org To: Mark H Weaver Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Thu Jan 31 11:01:18 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1U0qxI-0002Fn-7d for guile-devel@m.gmane.org; Thu, 31 Jan 2013 11:01:16 +0100 Original-Received: from localhost ([::1]:54924 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0qx0-0005of-6u for guile-devel@m.gmane.org; Thu, 31 Jan 2013 05:00:58 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:52626) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0qww-0005lP-SU for guile-devel@gnu.org; Thu, 31 Jan 2013 05:00:56 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1U0qwq-0004WX-Dp for guile-devel@gnu.org; Thu, 31 Jan 2013 05:00:54 -0500 Original-Received: from a-pb-sasl-quonix.pobox.com ([208.72.237.25]:35365 helo=sasl.smtp.pobox.com) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1U0qwq-0004WQ-93; Thu, 31 Jan 2013 05:00:48 -0500 Original-Received: from sasl.smtp.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id A9A50920B; Thu, 31 Jan 2013 05:00:47 -0500 (EST) DKIM-Signature: v=1; a=rsa-sha1; c=relaxed; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; s=sasl; bh=TCWRKfzkTculaOXiN+YB4E7zWkA=; b=WhKj6x H1Hhb5odnkvkhw9oGmgPzqRicrnwdYWlmQAlNUCwlPOlTGuulCuLWw+UmrU2tHVa L7rwEcQkZ8C5lz9/bAfWSSp0JfBir2vJ1+tND6htlK0UWhuR8J89r903ie0Lhywr 5mqhyCTaaKALzewK2nAFpfgtuoHQKOlJh+Cnc= DomainKey-Signature: a=rsa-sha1; c=nofws; d=pobox.com; h=from:to:cc :subject:references:date:in-reply-to:message-id:mime-version :content-type; q=dns; s=sasl; b=ZSV2tSi9BK3jWdMdhoZyfuXDkddioh82 zgRsl3e/jBmfGphcK/HQMx+g0bPM+C34sC0wt/xoPS9VgP0RgN2XFIR/5Uuj4m94 vDh3UH30jzQx6BzldOoiJFzZeo5bjPgRFZN3yH5Sly1zT8RRTCWdAmOsuT/Y0hq4 XSejCADzeYs= Original-Received: from a-pb-sasl-quonix.pobox.com (unknown [127.0.0.1]) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTP id A2A3F920A; Thu, 31 Jan 2013 05:00:47 -0500 (EST) Original-Received: from badger (unknown [88.160.190.192]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by a-pb-sasl-quonix.pobox.com (Postfix) with ESMTPSA id 33A379209; Thu, 31 Jan 2013 05:00:47 -0500 (EST) In-Reply-To: <878v7ahrfz.fsf_-_@tines.lan> (Mark H. Weaver's message of "Thu, 31 Jan 2013 00:06:24 -0500") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) X-Pobox-Relay-ID: 15B730B2-6B8D-11E2-A76E-0A4F0E5B5709-02397024!a-pb-sasl-quonix.pobox.com X-detected-operating-system: by eggs.gnu.org: Solaris 10 X-Received-From: 208.72.237.25 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:15640 Archived-At: On Thu 31 Jan 2013 06:06, Mark H Weaver writes: > From: Mark H Weaver > Date: Wed, 30 Jan 2013 14:45:28 -0500 > Subject: [PATCH] Do not scan for coding declarations in open-file. The patch looks good to me but I am concerned about the behavior change, and that it is inconvenient to get the previous behavior. My instinct is that we should not merge this patch without including a way to enable the coding sniff; which seems to mean adding keywords or somehow extending the arguments of: open-file with-input-from-file with-output-to-file call-with-output-file call-with-input-file open-input-file Dunno; that is a larger task. I'd be interested in Ludovic's thoughts as well. Andy -- http://wingolog.org/