From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add private port structure, and move iconv descriptors there Date: Mon, 01 Apr 2013 00:08:37 +0200 Message-ID: <87mwtj1au2.fsf@gnu.org> References: <87vc9ij5z0.fsf@pobox.com> <87fw0l2yyk.fsf@gnu.org> <877gltxgrg.fsf_-_@tines.lan> <87y5e8stst.fsf@pobox.com> <87d2vdekws.fsf@tines.lan> <87d2uk62a0.fsf_-_@tines.lan> <87a9poin2d.fsf@pobox.com> <8738vb5p7x.fsf@tines.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1364767738 6806 80.91.229.3 (31 Mar 2013 22:08:58 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 31 Mar 2013 22:08:58 +0000 (UTC) Cc: Andy Wingo , guile-devel@gnu.org To: Mark H Weaver Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Apr 01 00:09:24 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UMQRE-0001bF-Or for guile-devel@m.gmane.org; Mon, 01 Apr 2013 00:09:20 +0200 Original-Received: from localhost ([::1]:48709 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMQQq-0001i4-8G for guile-devel@m.gmane.org; Sun, 31 Mar 2013 18:08:56 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:57445) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMQQk-0001dj-9F for guile-devel@gnu.org; Sun, 31 Mar 2013 18:08:52 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UMQQg-0007jX-TO for guile-devel@gnu.org; Sun, 31 Mar 2013 18:08:50 -0400 Original-Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=43056 helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UMQQg-0007Xp-Mu for guile-devel@gnu.org; Sun, 31 Mar 2013 18:08:46 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by xanadu.aquilenet.fr (Postfix) with ESMTP id 3644CC8B0; Mon, 1 Apr 2013 00:08:38 +0200 (CEST) Original-Received: from xanadu.aquilenet.fr ([127.0.0.1]) by localhost (xanadu.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 2fIe3Hkhwhzu; Mon, 1 Apr 2013 00:08:38 +0200 (CEST) Original-Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by xanadu.aquilenet.fr (Postfix) with ESMTPSA id 9B5E2C836; Mon, 1 Apr 2013 00:08:37 +0200 (CEST) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 12 Germinal an 221 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu In-Reply-To: <8738vb5p7x.fsf@tines.lan> (Mark H. Weaver's message of "Sun, 31 Mar 2013 15:44:18 -0400") User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2a01:e0b:1:123:ca0a:a9ff:fe03:271e X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:16072 Archived-At: Mark H Weaver skribis: > Andy Wingo writes: >> Can you take a look at porting >> 6c98257f2ead0855f218369ea7f9a823cdb9727e? > > Okay, here's an updated patch set that's essentially a backport of that > commit from master, but with 'encoding_mode' and 'iconv_descriptors' put > in the internal-only port structure. I=E2=80=99m not familiar with how things are done in =E2=80=98master=E2=80= =99. From a 2.0 perspective, it looks good to me. Thanks, Ludo=E2=80=99.