From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: Make system* available on MS-Windows Date: Wed, 02 Jul 2014 11:55:56 +0200 Message-ID: <87mwcsythv.fsf@gnu.org> References: <831tu65tcp.fsf@gnu.org> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1404294984 9614 80.91.229.3 (2 Jul 2014 09:56:24 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 2 Jul 2014 09:56:24 +0000 (UTC) Cc: Mark H Weaver , guile-devel@gnu.org To: Eli Zaretskii Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Jul 02 11:56:17 2014 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1X2HGy-0002yp-I9 for guile-devel@m.gmane.org; Wed, 02 Jul 2014 11:56:16 +0200 Original-Received: from localhost ([::1]:52142 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2HGy-00033d-4W for guile-devel@m.gmane.org; Wed, 02 Jul 2014 05:56:16 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:56888) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2HGr-00032O-4S for guile-devel@gnu.org; Wed, 02 Jul 2014 05:56:14 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1X2HGl-0006fA-MD for guile-devel@gnu.org; Wed, 02 Jul 2014 05:56:09 -0400 Original-Received: from hera.aquilenet.fr ([2a01:474::1]:56765) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1X2HGf-0006e1-MM; Wed, 02 Jul 2014 05:55:57 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by hera.aquilenet.fr (Postfix) with ESMTP id 112A13063; Wed, 2 Jul 2014 11:55:57 +0200 (CEST) Original-Received: from hera.aquilenet.fr ([127.0.0.1]) by localhost (hera.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id TBur5XScAJxy; Wed, 2 Jul 2014 11:55:56 +0200 (CEST) Original-Received: from pluto (pluto.sophia.inria.fr [138.96.204.192]) by hera.aquilenet.fr (Postfix) with ESMTPSA id C1F5C1827; Wed, 2 Jul 2014 11:55:56 +0200 (CEST) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 14 Messidor an 222 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu In-Reply-To: <831tu65tcp.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 30 Jun 2014 18:07:18 +0300") User-Agent: Gnus/5.130009 (Ma Gnus v0.9) Emacs/24.3 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: Error: Malformed IPv6 address (bad octet value). X-Received-From: 2a01:474::1 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:17262 Archived-At: Eli Zaretskii skribis: > This function was disabled on Windows because its implementation used > 'fork' and 'waitpid'. The patch below makes system* available on > Windows: > > --- libguile/simpos.c~0 2014-02-28 23:01:27 +0200 > +++ libguile/simpos.c 2014-06-30 13:55:11 +0300 > @@ -45,6 +45,10 @@ > # include > #endif >=20=20 > +#ifdef __MINGW32__ > +#include Please add a margin comment on this line reading =E2=80=9Cfor waitpid=E2=80= =9D or something like that. Also leave a space after the sharp sign. > @@ -115,11 +117,17 @@ SCM_DEFINE (scm_system_star, "system*", > if (scm_is_pair (args)) > { > SCM oldint; > - SCM oldquit; > SCM sig_ign; > SCM sigint; > +#ifdef SIGQUIT Please add a margin comment saying that SIGQUIT is undefined on MinGW. OK to push with these changes, thank you! Ludo=E2=80=99.