unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Eli Zaretskii <eliz@gnu.org>
Cc: Mark H Weaver <mhw@netris.org>, guile-devel@gnu.org
Subject: Re: Make system* available on MS-Windows
Date: Wed, 02 Jul 2014 11:55:56 +0200	[thread overview]
Message-ID: <87mwcsythv.fsf@gnu.org> (raw)
In-Reply-To: <831tu65tcp.fsf@gnu.org> (Eli Zaretskii's message of "Mon, 30 Jun 2014 18:07:18 +0300")

Eli Zaretskii <eliz@gnu.org> skribis:

> This function was disabled on Windows because its implementation used
> 'fork' and 'waitpid'.  The patch below makes system* available on
> Windows:
>
> --- libguile/simpos.c~0	2014-02-28 23:01:27 +0200
> +++ libguile/simpos.c	2014-06-30 13:55:11 +0300
> @@ -45,6 +45,10 @@
>  # include <sys/wait.h>
>  #endif
>  
> +#ifdef __MINGW32__
> +#include <process.h>

Please add a margin comment on this line reading “for waitpid” or
something like that.  Also leave a space after the sharp sign.

> @@ -115,11 +117,17 @@ SCM_DEFINE (scm_system_star, "system*",
>    if (scm_is_pair (args))
>      {
>        SCM oldint;
> -      SCM oldquit;
>        SCM sig_ign;
>        SCM sigint;
> +#ifdef SIGQUIT

Please add a margin comment saying that SIGQUIT is undefined on MinGW.

OK to push with these changes, thank you!

Ludo’.



  reply	other threads:[~2014-07-02  9:55 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-06-30 15:07 Make system* available on MS-Windows Eli Zaretskii
2014-07-02  9:55 ` Ludovic Courtès [this message]
2014-07-02 15:39   ` Eli Zaretskii

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87mwcsythv.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=eliz@gnu.org \
    --cc=guile-devel@gnu.org \
    --cc=mhw@netris.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).