From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: David Thompson Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] ice-9: Add JSON module. Date: Sat, 15 Aug 2015 21:33:40 -0400 Message-ID: <87mvxs10gb.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> References: <87vbcg1c4d.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain X-Trace: ger.gmane.org 1439688841 1365 80.91.229.3 (16 Aug 2015 01:34:01 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sun, 16 Aug 2015 01:34:01 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Aug 16 03:33:53 2015 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1ZQmpZ-0000Ib-Nr for guile-devel@m.gmane.org; Sun, 16 Aug 2015 03:33:49 +0200 Original-Received: from localhost ([::1]:51234 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQmpY-0001yg-Iy for guile-devel@m.gmane.org; Sat, 15 Aug 2015 21:33:48 -0400 Original-Received: from eggs.gnu.org ([2001:4830:134:3::10]:44531) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQmpW-0001ya-3y for guile-devel@gnu.org; Sat, 15 Aug 2015 21:33:46 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ZQmpV-0006pJ-9n for guile-devel@gnu.org; Sat, 15 Aug 2015 21:33:46 -0400 Original-Received: from mail.fsf.org ([208.118.235.13]:44736) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1ZQmpV-0006oy-6t for guile-devel@gnu.org; Sat, 15 Aug 2015 21:33:45 -0400 Original-Received: from 209-6-40-86.c3-0.smr-ubr1.sbo-smr.ma.cable.rcn.com ([209.6.40.86]:32843 helo=izanagi) by mail.fsf.org with esmtpsa (TLS-1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.69) (envelope-from ) id 1ZQmpR-0004Ox-Hq for guile-devel@gnu.org; Sat, 15 Aug 2015 21:33:42 -0400 In-Reply-To: <87vbcg1c4d.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> User-Agent: Notmuch/0.19 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-unknown-linux-gnu) X-detected-operating-system: by mail.fsf.org: GNU/Linux 2.2.x-3.x [generic] X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 208.118.235.13 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:17789 Archived-At: Noticed a couple of small issues after I sent the initial patch that I've fixed in my local git branch: David Thompson writes: > +(define-module (ice-9 json) > + #:use-module (ice-9 match) > + #:use-module (srfi srfi-1) > + #:export (read-json write-json)) No need to import SRFI-1. > +(define (read-zeroes port) > + "Read a sequence of zeroes from PORT." > + (let loop ((result '())) > + (match (peek-char port) > + ((? eof-object?) > + result) > + (#\0 > + (read-char port) > + (loop (cons 0 result))) > + (else result)))) Never used. Removed. -- David Thompson GPG Key: 0FF1D807