From: David Thompson <davet@gnu.org>
To: guile-devel@gnu.org
Subject: Re: [PATCH] ice-9: Add JSON module.
Date: Sat, 15 Aug 2015 21:33:40 -0400 [thread overview]
Message-ID: <87mvxs10gb.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me> (raw)
In-Reply-To: <87vbcg1c4d.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me>
Noticed a couple of small issues after I sent the initial patch that
I've fixed in my local git branch:
David Thompson <davet@gnu.org> writes:
> +(define-module (ice-9 json)
> + #:use-module (ice-9 match)
> + #:use-module (srfi srfi-1)
> + #:export (read-json write-json))
No need to import SRFI-1.
> +(define (read-zeroes port)
> + "Read a sequence of zeroes from PORT."
> + (let loop ((result '()))
> + (match (peek-char port)
> + ((? eof-object?)
> + result)
> + (#\0
> + (read-char port)
> + (loop (cons 0 result)))
> + (else result))))
Never used. Removed.
--
David Thompson
GPG Key: 0FF1D807
next prev parent reply other threads:[~2015-08-16 1:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-08-15 21:21 [PATCH] ice-9: Add JSON module David Thompson
2015-08-16 1:33 ` David Thompson [this message]
2015-08-17 15:10 ` Christopher Allan Webber
2015-09-21 20:08 ` Ludovic Courtès
2015-09-22 1:31 ` Matt Wette
2015-09-22 6:49 ` Mark H Weaver
2015-09-22 12:43 ` Matt Wette
2015-09-22 6:46 ` Mark H Weaver
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mvxs10gb.fsf@izanagi.i-did-not-set--mail-host-address--so-tickle-me \
--to=davet@gnu.org \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).