unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
* resolve-module / scm_resolve_module
@ 2004-04-30 21:18 Dirk Herrmann
  2004-05-03 21:46 ` Marius Vollmer
  0 siblings, 1 reply; 2+ messages in thread
From: Dirk Herrmann @ 2004-04-30 21:18 UTC (permalink / raw)
  Cc: Guile-Devel Mailing List

Hello Marius,

I am about to submit the following patch. With this patch, 
scm_resolve_module will work, independent of what the current module is: 
The module lookup will always start at the root module. Could you please 
verify that this patch is alright and does not break anything?

Thanks,
Dirk


RCS file: /cvsroot/guile/guile/guile-core/ice-9/boot-9.scm,v
retrieving revision 1.330
diff -u -b -r1.330 boot-9.scm
--- ice-9/boot-9.scm    18 Feb 2004 22:29:45 -0000      1.330
+++ ice-9/boot-9.scm    30 Apr 2004 20:15:55 -0000
@@ -1727,7 +1727,7 @@
 ;;
 (define (resolve-module name . maybe-autoload)
   (let ((full-name (append '(app modules) name)))
-    (let ((already (local-ref full-name)))
+    (let ((already (nested-ref the-root-module full-name)))
       (if already
          ;; The module already exists...
          (if (and (or (null? maybe-autoload) (car maybe-autoload))




_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: resolve-module / scm_resolve_module
  2004-04-30 21:18 resolve-module / scm_resolve_module Dirk Herrmann
@ 2004-05-03 21:46 ` Marius Vollmer
  0 siblings, 0 replies; 2+ messages in thread
From: Marius Vollmer @ 2004-05-03 21:46 UTC (permalink / raw)
  Cc: Guile-Devel Mailing List

Dirk Herrmann <dirk@dirk-herrmanns-seiten.de> writes:

> I am about to submit the following patch. With this patch,
> scm_resolve_module will work, independent of what the current module
> is: The module lookup will always start at the root module. Could you
> please verify that this patch is alright and does not break anything?

Yes, I think this is a good change, please make it.

The whole local-ref / global / (app modules ...) setup should be
removed sometime, I'd say...  I think it is best to put the modules
into their own namespace.

-- 
GPG: D5D4E405 - 2F9B BCCC 8527 692A 04E3  331E FAF8 226A D5D4 E405


_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2004-05-03 21:46 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-04-30 21:18 resolve-module / scm_resolve_module Dirk Herrmann
2004-05-03 21:46 ` Marius Vollmer

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).