From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: Pkgsrc patches: patch-ae Date: Sat, 16 Feb 2008 19:49:01 +0100 Message-ID: <87lk5kn3du.fsf@gnu.org> References: <87tzketg12.fsf@gnu.org> <87y79puca8.fsf@ossau.uklinux.net> <87prv0sixe.fsf@inbox.ru> <87ejbg0yhj.fsf@ambire.localdomain> <87odajqv8s.fsf@inbox.ru> <87ir0r9yrb.fsf_-_@gnu.org> NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1203187769 22426 80.91.229.12 (16 Feb 2008 18:49:29 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 16 Feb 2008 18:49:29 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sat Feb 16 19:49:53 2008 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1JQS6g-0000IK-VG for guile-devel@m.gmane.org; Sat, 16 Feb 2008 19:49:51 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JQS6C-0000Gb-SI for guile-devel@m.gmane.org; Sat, 16 Feb 2008 13:49:20 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1JQS66-0000Fi-Fk for guile-devel@gnu.org; Sat, 16 Feb 2008 13:49:14 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1JQS65-0000FP-Km for guile-devel@gnu.org; Sat, 16 Feb 2008 13:49:14 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1JQS65-0000FK-2q for guile-devel@gnu.org; Sat, 16 Feb 2008 13:49:13 -0500 Original-Received: from main.gmane.org ([80.91.229.2] helo=ciao.gmane.org) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1JQS64-0000Q0-Ot for guile-devel@gnu.org; Sat, 16 Feb 2008 13:49:13 -0500 Original-Received: from list by ciao.gmane.org with local (Exim 4.43) id 1JQS62-0002oO-HA for guile-devel@gnu.org; Sat, 16 Feb 2008 18:49:10 +0000 Original-Received: from reverse-83.fdn.fr ([80.67.176.83]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 16 Feb 2008 18:49:10 +0000 Original-Received: from ludo by reverse-83.fdn.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sat, 16 Feb 2008 18:49:10 +0000 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 63 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: reverse-83.fdn.fr X-Revolutionary-Date: 28 =?iso-8859-1?Q?Pluvi=F4se?= an 216 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEB1F5364 X-PGP-Key: http://www.laas.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: i686-pc-linux-gnu User-Agent: Gnus/5.11 (Gnus v5.11) Emacs/22.1 (gnu/linux) Cancel-Lock: sha1:jDCmJrRcDBdwMkqLQ/v3HjqgQ+s= X-detected-kernel: by monty-python.gnu.org: Linux 2.6, seldom 2.4 (older, 4) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:7017 Archived-At: Hi, Greg Troxel writes: > This just adds defines for more platforms, plus fixes a comment typo. > > $NetBSD: patch-ae,v 1.13 2007/07/20 00:09:22 gdt Exp $ > > support for NetBSD/alpha, NetBSD/sparc64, and NetBSD/x86_64 > I'm unclear about some of the changes below. > -# if defined(__NetBSD__) && defined(__sparc__) > +# if defined(__NetBSD__) && (defined(__sparc__) || defined(__sparc_v9__)) Two questions: 1. Isn't `__sparc__' defined on V9? On GNU/Linux, it seems that it is defined on both V9 and V8, so no special treatment is required. 2. Unless I'm mistaken, this is equivalent to #if (defined(__NetBSD__) && (defined(__sparc__))) || (defined(__sparc_v9__)) while this should probably be: #if defined(__NetBSD__) && (defined(__sparc__) || (defined(__sparc_v9__))) > +# if defined(__NetBSD__) && defined(__x86_64__) > +# define X86_64 > +# define NETBSD > +# define mach_type_known > +# endif [...] > +# ifdef X86_64 > +# define MACH_TYPE "X86_64" > +# define ALIGNMENT 8 > +# define ALIGN_DOUBLE > +# define CPP_WORDSZ 64 > +# ifdef NETBSD > +# define OS_TYPE "NETBSD" > +# endif > +# if defined(NETBSD) > +# define HEURISTIC2 > + extern char etext; > +# define DATASTART ((ptr_t)(&etext)) > +# endif > +# endif Strangely enough, we don't have `LINUX && __x86_64__' either. Interestingly, of these constants, it seems that Guile uses only `HEURISTIC2'. For instance, Guile's GC gets the alignment constraint through the definition of `SCM_STACKITEM'. Hence my question: didn't the NetBSD/i386 support suffice on x86-64? What exact problem did it solve? The other bits are indeed applicable. Thanks, Ludovic.