From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: Neil Jerram Newsgroups: gmane.lisp.guile.devel Subject: Re: minor SCM_DEBUG patch Date: Fri, 30 Oct 2009 21:23:09 +0000 Message-ID: <87ljis7f0i.fsf@ossau.uklinux.net> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: ger.gmane.org 1256937831 29697 80.91.229.12 (30 Oct 2009 21:23:51 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Fri, 30 Oct 2009 21:23:51 +0000 (UTC) Cc: guile-devel To: Ken Raeburn Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Fri Oct 30 22:23:44 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N3ywh-0006nZ-RE for guile-devel@m.gmane.org; Fri, 30 Oct 2009 22:23:44 +0100 Original-Received: from localhost ([127.0.0.1]:54204 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3ywh-0002Gy-7h for guile-devel@m.gmane.org; Fri, 30 Oct 2009 17:23:43 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N3ywG-00023q-6K for guile-devel@gnu.org; Fri, 30 Oct 2009 17:23:16 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N3ywB-00022e-I7 for guile-devel@gnu.org; Fri, 30 Oct 2009 17:23:15 -0400 Original-Received: from [199.232.76.173] (port=50267 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N3ywB-00022b-CH for guile-devel@gnu.org; Fri, 30 Oct 2009 17:23:11 -0400 Original-Received: from mail3.uklinux.net ([80.84.72.33]:38559) by monty-python.gnu.org with esmtp (Exim 4.60) (envelope-from ) id 1N3ywB-0001GK-2S for guile-devel@gnu.org; Fri, 30 Oct 2009 17:23:11 -0400 Original-Received: from arudy (host86-147-112-196.range86-147.btcentralplus.com [86.147.112.196]) by mail3.uklinux.net (Postfix) with ESMTP id 5A5621F685A; Fri, 30 Oct 2009 21:23:10 +0000 (GMT) Original-Received: from arudy (arudy [127.0.0.1]) by arudy (Postfix) with ESMTP id E0E6538024; Fri, 30 Oct 2009 21:23:09 +0000 (GMT) In-Reply-To: (Ken Raeburn's message of "Thu, 29 Oct 2009 13:51:26 -0400") User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.4-2.6 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:9613 Archived-At: Ken Raeburn writes: > The SCM_GC_MARK_P macro doesn't exist any more, but is still mentioned > in a few places. With SCM_DEBUG defined, one of them actually gets > compiled. While looking at this, I also noticed three macros in > deprecated.h (which were there in 1.8) which use non-existent macros > including SCM_GC_MARK_P, and deleted those too. I didn't touch the > other uses of SCM_GC_MARK_P in futures.c. This patch looks good to me too. > Related but not addressed here: Several places still check > scm_gc_running_p and conditionally execute code (or not), but it's now > defined as a macro always expanding to 0. After reviewing them, I'm pretty sure it would be OK to remove all of those too. They're mostly to do with not being able to generate a libguile exception during GC, and I believe that that possibility just doesn't exist now. (Because the within-GC code is nothing to do with libguile.) Regards, Neil