From: Neil Jerram <neil@ossau.uklinux.net>
To: Ken Raeburn <raeburn@raeburn.org>
Cc: guile-devel <guile-devel@gnu.org>
Subject: Re: minor SCM_DEBUG patch
Date: Fri, 30 Oct 2009 21:23:09 +0000 [thread overview]
Message-ID: <87ljis7f0i.fsf@ossau.uklinux.net> (raw)
In-Reply-To: <DF2C427C-DA67-46D5-905B-486A998C4A32@raeburn.org> (Ken Raeburn's message of "Thu, 29 Oct 2009 13:51:26 -0400")
Ken Raeburn <raeburn@raeburn.org> writes:
> The SCM_GC_MARK_P macro doesn't exist any more, but is still mentioned
> in a few places. With SCM_DEBUG defined, one of them actually gets
> compiled. While looking at this, I also noticed three macros in
> deprecated.h (which were there in 1.8) which use non-existent macros
> including SCM_GC_MARK_P, and deleted those too. I didn't touch the
> other uses of SCM_GC_MARK_P in futures.c.
This patch looks good to me too.
> Related but not addressed here: Several places still check
> scm_gc_running_p and conditionally execute code (or not), but it's now
> defined as a macro always expanding to 0.
After reviewing them, I'm pretty sure it would be OK to remove all of
those too. They're mostly to do with not being able to generate a
libguile exception during GC, and I believe that that possibility just
doesn't exist now. (Because the within-GC code is nothing to do with
libguile.)
Regards,
Neil
next prev parent reply other threads:[~2009-10-30 21:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 17:51 minor SCM_DEBUG patch Ken Raeburn
2009-10-30 21:23 ` Neil Jerram [this message]
2009-10-31 23:11 ` Ludovic Courtès
2009-11-03 1:47 ` Ken Raeburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ljis7f0i.fsf@ossau.uklinux.net \
--to=neil@ossau.uklinux.net \
--cc=guile-devel@gnu.org \
--cc=raeburn@raeburn.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).