unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Kan-Ru Chen <kanru@kanru.info>
To: guile-devel@gnu.org
Subject: Re: ECMAScript support broken?
Date: Mon, 03 Jan 2011 16:19:14 +0800	[thread overview]
Message-ID: <87lj32mmbh.fsf@anar.kanru.info> (raw)
In-Reply-To: <AANLkTimtXDqrd9ixKaF4Jp4y9OdONpg6vaFDErYXy33K@mail.gmail.com> (Noah Lavine's message of "Sun, 2 Jan 2011 22:19:45 -0500")

Hi,

Noah Lavine <noah.b.lavine@gmail.com> writes:

> Hi all,
>
> I looked at this. For the first error, I think the bug is in (language
> ecmascript compile-tree-il), where the file around line 369 says:
>
>       ((object . ,args)
>            (@impl new-object
>                   (map (lambda (x)
>                          (pmatch x
>                                  ((,prop ,val)
>                                   (-> (apply (-> (primitive 'cons))
>                                              (-> (const prop))
>                                              (comp val e))))
>                                  (else
>                                   (error "bad prop-val pair" x))))
>                        args)))

I don't know the guile internal (yet), but after looking around
(language tree-il) and (language ecmascript base) it seems `new-object'
want a list of pairs instead a list of lists.  I changed the above code
to

       `(apply ,(@implv new-object)
               ,@(map (lambda (x)
                        (pmatch x
                                ((,prop ,val)
                                 (-> (apply (-> (primitive 'cons))
                                            (-> (const prop))
                                            (comp val e))))
                                (else
                                 (error "bad prop-val pair" x))))
                      args)))

and it works.

Hope this helps you to diagnose the problem.

Cheers,
Kanru
-- 
A badly written book is only a blunder. A bad translation of a good
book is a crime.
                -- Gilbert Highet



      parent reply	other threads:[~2011-01-03  8:19 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-01-02 16:46 ECMAScript support broken? Kan-Ru Chen
2011-01-03  3:19 ` Noah Lavine
2011-01-03  7:25   ` Noah Lavine
2011-01-03  8:42     ` Kan-Ru Chen
2011-01-03 17:54       ` Noah Lavine
2011-01-04  9:23         ` Sputnik test result (was Re: ECMAScript support broken?) Kan-Ru Chen
2011-01-11 21:38           ` Noah Lavine
2011-01-11 22:33             ` Noah Lavine
2011-01-11 22:45               ` Noah Lavine
2011-01-11 22:59                 ` Noah Lavine
2011-01-11 23:04                   ` Noah Lavine
2011-01-17 22:07             ` Ludovic Courtès
2011-01-26 22:49               ` Ludovic Courtès
2011-01-26 23:30                 ` Noah Lavine
2011-01-27 16:08           ` Sputnik test result Andy Wingo
2011-01-27 16:12             ` Noah Lavine
2011-01-27 17:01               ` Kan-Ru Chen
2011-01-03 23:00     ` ECMAScript support broken? Ludovic Courtès
2011-01-04  4:10       ` Noah Lavine
2011-01-04 16:52         ` Kan-Ru Chen
2011-01-04 17:39           ` Noah Lavine
2011-01-04 17:38         ` Ludovic Courtès
2011-01-03  8:19   ` Kan-Ru Chen [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87lj32mmbh.fsf@anar.kanru.info \
    --to=kanru@kanru.info \
    --cc=guile-devel@gnu.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).