From: ludo@gnu.org (Ludovic Courtès)
To: Mark H Weaver <mhw@netris.org>
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH et al
Date: Thu, 29 Nov 2012 11:27:07 +0100 [thread overview]
Message-ID: <87lidkembo.fsf@gnu.org> (raw)
In-Reply-To: <871ufdxg6m.fsf@tines.lan> (Mark H. Weaver's message of "Wed, 28 Nov 2012 22:04:49 -0500")
Hi Mark!
Mark H Weaver <mhw@netris.org> skribis:
> Hi Ludovic,
>
> ludo@gnu.org (Ludovic Courtès) writes:
>> Mark H Weaver <mhw@netris.org> skribis:
>>
>>> +#define FUNC_NAME s_scm_parse_path_with_ellipsis
>>> +{
>>> + SCM ellipsis = scm_from_latin1_string ("...");
>>
>> Use ‘SCM_SYMBOL’ instead.
>
> It's a string, not a symbol.
Oops, right. Then there’s SCM_IMMUTABLE_STRING. :-)
> I've attached a revised patch that also does a much better job of
> updating the docs. I also noticed that the documentation of the default
> load path did not match reality.
Excellent, looks great to me.
If everything goes well, we may be able to tag tonight. WDYT?
Thanks,
Ludo’.
prev parent reply other threads:[~2012-11-29 10:27 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-11-05 3:18 Adding to the end of the load path Ian Price
2012-11-08 1:03 ` Andreas Rottmann
2012-11-11 7:50 ` Mark H Weaver
2012-11-11 19:02 ` Andreas Rottmann
2012-11-11 21:51 ` Mark H Weaver
2012-11-12 16:35 ` Bruce Korb
2012-11-13 21:04 ` Ludovic Courtès
2012-11-15 22:06 ` Andreas Rottmann
2012-11-15 22:37 ` Ludovic Courtès
2012-11-15 22:44 ` Mark H Weaver
2012-11-15 23:06 ` Ludovic Courtès
2012-11-16 0:10 ` Noah Lavine
2012-11-16 14:00 ` Noah Lavine
2012-11-16 18:06 ` Bruce Korb
2012-11-16 18:52 ` Mark H Weaver
2012-11-16 21:38 ` Noah Lavine
2012-11-28 23:12 ` [PATCH] Add parse-path-with-ellipsis, and use it for GUILE_LOAD_PATH et al Mark H Weaver
2012-11-28 23:46 ` Ludovic Courtès
2012-11-29 3:04 ` Mark H Weaver
2012-11-29 10:27 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lidkembo.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guile-devel@gnu.org \
--cc=mhw@netris.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).