From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.io!.POSTED.blaine.gmane.org!not-for-mail From: Andy Wingo Newsgroups: gmane.lisp.guile.devel Subject: Re: Some non-standard O_* flags are missing Date: Wed, 10 Mar 2021 21:08:20 +0100 Message-ID: <87lfau22mj.fsf@pobox.com> References: <87mtvc2hfa.fsf@pobox.com> <17e5d28f64768602b6e1eb164e82f90b58c5209d.camel@telenet.be> Mime-Version: 1.0 Content-Type: text/plain Injection-Info: ciao.gmane.io; posting-host="blaine.gmane.org:116.202.254.214"; logging-data="34954"; mail-complaints-to="usenet@ciao.gmane.io" User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) Cc: Andy Wingo , guile-devel@gnu.org To: Maxime Devos Original-X-From: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Wed Mar 10 21:09:00 2021 Return-path: Envelope-to: guile-devel@m.gmane-mx.org Original-Received: from lists.gnu.org ([209.51.188.17]) by ciao.gmane.io with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lK58c-0008vR-HM for guile-devel@m.gmane-mx.org; Wed, 10 Mar 2021 21:08:58 +0100 Original-Received: from localhost ([::1]:57728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1lK58b-0005kr-J1 for guile-devel@m.gmane-mx.org; Wed, 10 Mar 2021 15:08:57 -0500 Original-Received: from eggs.gnu.org ([2001:470:142:3::10]:57996) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1lK58M-0005j9-KH for guile-devel@gnu.org; Wed, 10 Mar 2021 15:08:42 -0500 Original-Received: from fanzine.igalia.com ([178.60.130.6]:54653) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1lK58I-0005tH-CY for guile-devel@gnu.org; Wed, 10 Mar 2021 15:08:41 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=igalia.com; s=20170329; h=Content-Type:MIME-Version:Message-ID:In-Reply-To:Date:References:Subject:Cc:To:From; bh=DGGUu4+s1SyEmsbcIRjySvUQ0rDqKIwNQeQdDMdO72E=; b=Sgcrh9q49Mh75+ldPxNE1Mmh3sid1y8jYPDcCuTSPkPQeLKQlVV0aPNlYWla5HEON6+qfH8Ey0KKFgNXWZWCvIimWu/JaS9nH80+XwlIIwiBtba9jAO49NtzpX9auhOXIwNKCsjwxXxMGyJQWpRgOtvtYtTM4fbIzuVcrgUQ6HT16r+RYEdRm8sUK1WuDb40HEVR/CFbDCDq4SUKp2mITW99VPHgwbt3TYXd7QNIFwrjB7uP9F05NzKX4sJp/UwLnGCKcCyjfQMUP9bOFGo9A4rupH7PZXVANczXMlU3EaOQl8BbAzO0+WSpK+iozCQHJdGDcafe0wr8GVDVodOdjg==; Original-Received: from 82-65-63-215.subs.proxad.net ([82.65.63.215] helo=sparrow) by fanzine.igalia.com with esmtpsa (Cipher TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim) id 1lK58B-0006uR-1O; Wed, 10 Mar 2021 21:08:31 +0100 In-Reply-To: <17e5d28f64768602b6e1eb164e82f90b58c5209d.camel@telenet.be> (Maxime Devos's message of "Tue, 09 Mar 2021 22:47:20 +0100") Received-SPF: neutral client-ip=178.60.130.6; envelope-from=wingo@pobox.com; helo=fanzine.igalia.com X-Spam_score_int: -10 X-Spam_score: -1.1 X-Spam_bar: - X-Spam_report: (-1.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, SPF_HELO_NONE=0.001, SPF_NEUTRAL=0.779 autolearn=no autolearn_force=no X-Spam_action: no action X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane-mx.org@gnu.org Original-Sender: "guile-devel" Xref: news.gmane.io gmane.lisp.guile.devel:20704 Archived-At: Heya :) On Tue 09 Mar 2021 22:47, Maxime Devos writes: > On Tue, 2021-03-09 at 21:36 +0100, Andy Wingo wrote: >> Hi :) Sure, would be happy to accept a patch for these. > See > and messages above. I'll look at updating NEWS and the manual > later. Great! I agree it's weird that O_NOTRANS is defined but 0 on GNU/Linux. Perhaps better not to define it if it's zero? Dunno tho. >> It's adding >> more definitions to the base environment, which is usually a negative, >> but we'll have to find some kind of module solution for all of these >> flags at some point. > > Would defining O_* in a new module (ice-9 open-flags) > (or the existing module (ice-9 posix) maybe?) be acceptable? > Or alternatively, a syntax (open-flag SYMBOL) that expands to > the flag's value -- Let's punt for now :) >> If you do send a patch, please update the manual >> and NEWS also. > > The manual only documents O_RDONLY, O_WRONLY, O_RDWR, > O_APPEND and O_CREAT currently, and points the reader > at glibc's manual for additional flags. Ah yes. Probably the flags (possibly) supported by Guile should be in the manual. Document them if you have a moment? :) Otherwise just document the new ones. Andy