unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
* scm_round_number using scm_round
@ 2004-05-16 23:12 Kevin Ryde
  0 siblings, 0 replies; only message in thread
From: Kevin Ryde @ 2004-05-16 23:12 UTC (permalink / raw)


[-- Attachment #1: Type: text/plain, Size: 300 bytes --]

        * numbers.c (scm_round_number): For inum and big, just return x.  For
        real, use scm_round for problems with 2^54-1 etc covered there.

The problem that afflicted scm_round arises in the same algorithm done
with SCMs in scm_round_number.  I think it can call scm_round to share
code.


[-- Attachment #2: numbers.c.round-number.diff --]
[-- Type: text/plain, Size: 832 bytes --]

--- numbers.c.~1.243.~	2004-05-12 07:19:25.000000000 +1000
+++ numbers.c	2004-05-17 07:36:30.000000000 +1000
@@ -5007,6 +5007,15 @@
 	    "round towards the even one.")
 #define FUNC_NAME s_scm_round_number
 {
+  if (SCM_INUMP (x) || SCM_BIGP (x))
+    return x;
+  else if (SCM_REALP (x))
+    return scm_make_real (scm_round (SCM_REAL_VALUE (x)));
+  else
+    {
+      /* OPTIMIZE-ME: Fraction case could be done more efficiently by a
+         single quotient+remainder division then examining to see which way
+         the rounding should go.  */
   SCM plus_half = scm_sum (x, exactly_one_half);
   SCM result = scm_floor (plus_half);
   /* Adjust so that the scm_round is towards even.  */
@@ -5015,6 +5024,7 @@
     return scm_difference (result, SCM_MAKINUM (1));
   else
     return result;
+    }
 }
 #undef FUNC_NAME
 

[-- Attachment #3: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel

^ permalink raw reply	[flat|nested] only message in thread

only message in thread, other threads:[~2004-05-16 23:12 UTC | newest]

Thread overview: (only message) (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2004-05-16 23:12 scm_round_number using scm_round Kevin Ryde

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).