From: Kevin Ryde <user42@zip.com.au>
Subject: Re: [PATCH] Inlining `scm_is_pair ()'
Date: Wed, 25 Jan 2006 07:12:15 +1100 [thread overview]
Message-ID: <87k6cpwfkw.fsf@zip.com.au> (raw)
In-Reply-To: <87slrednt9.fsf_-_@laas.fr> (Ludovic Courtès's message of "Tue, 24 Jan 2006 09:37:06 +0100")
ludovic.courtes@laas.fr (Ludovic Courtès) writes:
>
> The following patch makes `scm_is_pair ()' an inline --- the macro was
> indeed a bad idea because there are places (e.g., async.c:208) where its
> argument is an assignment.
Which is probably not really in line with gnu coding standards
(standards.info end of "Syntactic Conventions" node). But I guess any
application might do it.
> I'm not sure that's the only reason, but I'm now unable to compile Guile
> with `-O0': when doing so, I get a "stack overflow" error when trying to
> run the REPL. Perhaps we should also declare the function with
> `__attribute__ ((always_inline))'?
That was ceval/deval() local variables on gcc 4 last time I hit that.
-O1 may be better, or just on eval.c at least.
> +static SCM_C_INLINE int
I suspect extern inline is what you want, static inline might end up
with a copy of the code in every file, under -O0 at least. But extern
inline is even more of a gcc-ism, if you're worried about the
commercial compilers.
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2006-01-24 20:12 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2005-12-14 14:46 [PATCH] Turning `scm_is_pair ()' into a macro Ludovic Courtès
2005-12-14 20:57 ` Kevin Ryde
2005-12-14 23:00 ` Han-Wen Nienhuys
2005-12-14 23:19 ` Marius Vollmer
2005-12-15 9:39 ` Ludovic Courtès
2005-12-16 0:08 ` Han-Wen Nienhuys
2005-12-16 10:01 ` Ludovic Courtès
2006-01-24 8:37 ` [PATCH] Inlining `scm_is_pair ()' Ludovic Courtès
2006-01-24 20:12 ` Kevin Ryde [this message]
2006-01-25 9:21 ` Ludovic Courtès
2006-01-26 23:13 ` Kevin Ryde
2006-01-27 9:13 ` Ludovic Courtès
2006-01-28 22:07 ` Marius Vollmer
2006-01-30 9:06 ` Ludovic Courtès
2006-02-03 23:49 ` Kevin Ryde
2006-02-05 19:10 ` Marius Vollmer
2005-12-16 0:41 ` [PATCH] Turning `scm_is_pair ()' into a macro Kevin Ryde
2005-12-16 20:01 ` Marius Vollmer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k6cpwfkw.fsf@zip.com.au \
--to=user42@zip.com.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).