From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: minor SCM_DEBUG patch Date: Sun, 01 Nov 2009 00:11:31 +0100 Message-ID: <87k4ybgnvg.fsf@gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1257030735 17902 80.91.229.12 (31 Oct 2009 23:12:15 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Sat, 31 Oct 2009 23:12:15 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Nov 01 00:12:08 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1N4N79-0006Ik-KH for guile-devel@m.gmane.org; Sun, 01 Nov 2009 00:12:07 +0100 Original-Received: from localhost ([127.0.0.1]:60353 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N4N79-0000tI-0v for guile-devel@m.gmane.org; Sat, 31 Oct 2009 19:12:07 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1N4N76-0000t4-40 for guile-devel@gnu.org; Sat, 31 Oct 2009 19:12:04 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1N4N71-0000rP-FD for guile-devel@gnu.org; Sat, 31 Oct 2009 19:12:03 -0400 Original-Received: from [199.232.76.173] (port=49622 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1N4N71-0000rM-A1 for guile-devel@gnu.org; Sat, 31 Oct 2009 19:11:59 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:49826) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1N4N70-0006Lk-Vb for guile-devel@gnu.org; Sat, 31 Oct 2009 19:11:59 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.50) id 1N4N6v-0006ES-2o for guile-devel@gnu.org; Sun, 01 Nov 2009 00:11:53 +0100 Original-Received: from reverse-83.fdn.fr ([80.67.176.83]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 01 Nov 2009 00:11:53 +0100 Original-Received: from ludo by reverse-83.fdn.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 01 Nov 2009 00:11:53 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 38 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: reverse-83.fdn.fr X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 11 Brumaire an 218 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) Cancel-Lock: sha1:2eP5/JLh4yQpDqKo5uzdAaFK13I= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:9623 Archived-At: Hello, Ken Raeburn writes: > The SCM_GC_MARK_P macro doesn't exist any more, but is still mentioned > in a few places. With SCM_DEBUG defined, one of them actually gets > compiled. While looking at this, I also noticed three macros in > deprecated.h (which were there in 1.8) which use non-existent macros > including SCM_GC_MARK_P, and deleted those too. I didn't touch the > other uses of SCM_GC_MARK_P in futures.c. Looks good to me. In addition we could add this to ‘deprecated.h’: #define SCM_GC_MARK_P scm_gc_mark_p SCM_DEPRECATED int scm_gc_mark_p (SCM obj); and: int scm_gc_mark_p (SCM obj) { /* `GC_is_visible ()' aborts if the given pointer is not visible to the GC. */ GC_is_visible (SCM2PTR (obj)); return 1; } What do you think? > Related but not addressed here: Several places still check > scm_gc_running_p and conditionally execute code (or not), but it's now > defined as a macro always expanding to 0. Likewise, we could leave it as a deprecated thing (always 0) and also remove its internal uses. Thanks, Ludo’.