From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: minor SCM_DEBUG patch
Date: Sun, 01 Nov 2009 00:11:31 +0100 [thread overview]
Message-ID: <87k4ybgnvg.fsf@gnu.org> (raw)
In-Reply-To: DF2C427C-DA67-46D5-905B-486A998C4A32@raeburn.org
Hello,
Ken Raeburn <raeburn@raeburn.org> writes:
> The SCM_GC_MARK_P macro doesn't exist any more, but is still mentioned
> in a few places. With SCM_DEBUG defined, one of them actually gets
> compiled. While looking at this, I also noticed three macros in
> deprecated.h (which were there in 1.8) which use non-existent macros
> including SCM_GC_MARK_P, and deleted those too. I didn't touch the
> other uses of SCM_GC_MARK_P in futures.c.
Looks good to me. In addition we could add this to ‘deprecated.h’:
#define SCM_GC_MARK_P scm_gc_mark_p
SCM_DEPRECATED int scm_gc_mark_p (SCM obj);
and:
int
scm_gc_mark_p (SCM obj)
{
/* `GC_is_visible ()' aborts if the given pointer is
not visible to the GC. */
GC_is_visible (SCM2PTR (obj));
return 1;
}
What do you think?
> Related but not addressed here: Several places still check
> scm_gc_running_p and conditionally execute code (or not), but it's now
> defined as a macro always expanding to 0.
Likewise, we could leave it as a deprecated thing (always 0) and also
remove its internal uses.
Thanks,
Ludo’.
next prev parent reply other threads:[~2009-10-31 23:11 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-29 17:51 minor SCM_DEBUG patch Ken Raeburn
2009-10-30 21:23 ` Neil Jerram
2009-10-31 23:11 ` Ludovic Courtès [this message]
2009-11-03 1:47 ` Ken Raeburn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k4ybgnvg.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).