unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Volker Grabsch <vog@notjusthosting.com>
Cc: guile-devel@gnu.org
Subject: Re: Portability fixes for win32 cross compiling
Date: Fri, 28 May 2010 15:10:09 +0200	[thread overview]
Message-ID: <87k4qof9zi.fsf@gnu.org> (raw)
In-Reply-To: <20100421202248.GA16263@flap> (Volker Grabsch's message of "Wed,  21 Apr 2010 22:22:48 +0200")

Hi Volker,

I’m finally in the process of reviewing and applying your patches.

Volker Grabsch <vog@notjusthosting.com> writes:

> From 6f2b554eb5cf6a5f580689b6418fbb28d7d42c7c Mon Sep 17 00:00:00 2001
> From: Volker Grabsch <vog@notjusthosting.com>
> Date: Wed, 21 Apr 2010 18:45:49 +0200
> Subject: [PATCH] remove an unused and dangling #include directive
>
> ---
>  libguile/objcodes.c |    1 -
>  1 files changed, 0 insertions(+), 1 deletions(-)
>
> diff --git a/libguile/objcodes.c b/libguile/objcodes.c
> index 2931468..47f6f3a 100644
> --- a/libguile/objcodes.c
> +++ b/libguile/objcodes.c
> @@ -23,7 +23,6 @@
>  #include <string.h>
>  #include <fcntl.h>
>  #include <unistd.h>
> -#include <sys/mman.h>
>  #include <sys/stat.h>
>  #include <sys/types.h>
>  #include <assert.h>

This one is wrong: the file uses mmap(3), which is declared in
<sys/mman.h> according to
<http://www.opengroup.org/onlinepubs/9699919799/functions/mmap.html>.

This function is missing on MinGW, though, but there’s currently no
replacement in Guile.  Would you like to work on it?

Thanks,
Ludo’.



  parent reply	other threads:[~2010-05-28 13:10 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-04-15  0:51 Portability fixes for win32 cross compiling Volker Grabsch
2010-04-15 14:12 ` Mike Gran
2010-04-15 20:58   ` Volker Grabsch
2010-04-21 20:22     ` Volker Grabsch
2010-05-03  9:17       ` Volker Grabsch
2010-05-03 12:31         ` Greg Troxel
2010-05-21 10:09       ` Andy Wingo
2010-05-22 13:44         ` Ludovic Courtès
2010-05-24 20:30         ` Volker Grabsch
2010-05-28 13:10       ` Ludovic Courtès [this message]
2010-05-28 14:56         ` Volker Grabsch
2010-06-08 22:01           ` Ludovic Courtès
2010-06-08 22:12           ` No Itisnt
2010-06-09  6:42             ` Andy Wingo
2010-07-28 12:40             ` Volker Grabsch
2010-05-28 13:15 ` Ludovic Courtès
2010-05-28 14:44   ` Volker Grabsch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k4qof9zi.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=guile-devel@gnu.org \
    --cc=vog@notjusthosting.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).