From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: The dynamic stack Date: Tue, 06 Mar 2012 18:20:45 +0100 Message-ID: <87k42xabo2.fsf@gnu.org> References: <87r4x9d52h.fsf@pobox.com> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1331054478 2176 80.91.229.3 (6 Mar 2012 17:21:18 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Tue, 6 Mar 2012 17:21:18 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Tue Mar 06 18:21:18 2012 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1S4y4b-0006Tr-NQ for guile-devel@m.gmane.org; Tue, 06 Mar 2012 18:21:17 +0100 Original-Received: from localhost ([::1]:43163 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4y4b-0003oL-0l for guile-devel@m.gmane.org; Tue, 06 Mar 2012 12:21:17 -0500 Original-Received: from eggs.gnu.org ([208.118.235.92]:56989) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4y4T-0003nU-Aa for guile-devel@gnu.org; Tue, 06 Mar 2012 12:21:14 -0500 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1S4y4M-0002Vn-ND for guile-devel@gnu.org; Tue, 06 Mar 2012 12:21:08 -0500 Original-Received: from plane.gmane.org ([80.91.229.3]:52938) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1S4y4M-0002Vb-Gd for guile-devel@gnu.org; Tue, 06 Mar 2012 12:21:02 -0500 Original-Received: from list by plane.gmane.org with local (Exim 4.69) (envelope-from ) id 1S4y4H-00067W-SX for guile-devel@gnu.org; Tue, 06 Mar 2012 18:20:57 +0100 Original-Received: from 193.50.110.167 ([193.50.110.167]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 06 Mar 2012 18:20:57 +0100 Original-Received: from ludo by 193.50.110.167 with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Tue, 06 Mar 2012 18:20:57 +0100 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 36 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: 193.50.110.167 X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 17 =?iso-8859-1?Q?Vent=F4se?= an 220 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.110018 (No Gnus v0.18) Emacs/24.0.93 (gnu/linux) Cancel-Lock: sha1:Cfz4gU/7d/ykT16xQ/giVEr89NI= X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 80.91.229.3 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:14026 Archived-At: Hi, Andy Wingo skribis: > I have pushed a patch to master that changes the implementation of the > dynamic stack The “dynwind stack” actually (I misread it the first time.) > from being a linked list on the heap to being an actual stack. This > allows us to push items on the stack in many cases without allocating > memory at all. Sounds great! Could you please add comments in dynstack.c (above each function), and make sure to follow GCS-style (no hanging brace, for example)? Regarding comments, I see that now ranks Guile as one of the least commented source code bases. There are many good reasons why we ought to do better here, IMO. WDYT? > This patch makes a simple "guile examples/web/debug-sxml.scm" server go > from serving 3215 reqs/s to 3830 reqs/s. (Using "ab -n 100000 -c100 > http://localhost:8080/" on the same machine to test; the machine is my > laptop. By way of comparison, stable-2.0 does 3225 reqs/s on that > benchmark.) Nice! Did you try a micro-benchmark that would ‘dynamic-wind’ repeatedly? Thanks, Ludo’.