From: ludo@gnu.org (Ludovic Courtès)
To: guile-devel@gnu.org
Subject: Re: The dynamic stack
Date: Tue, 06 Mar 2012 18:20:45 +0100 [thread overview]
Message-ID: <87k42xabo2.fsf@gnu.org> (raw)
In-Reply-To: 87r4x9d52h.fsf@pobox.com
Hi,
Andy Wingo <wingo@pobox.com> skribis:
> I have pushed a patch to master that changes the implementation of the
> dynamic stack
The “dynwind stack” actually (I misread it the first time.)
> from being a linked list on the heap to being an actual stack. This
> allows us to push items on the stack in many cases without allocating
> memory at all.
Sounds great!
Could you please add comments in dynstack.c (above each function), and
make sure to follow GCS-style (no hanging brace, for example)?
Regarding comments, I see that <https://www.ohloh.net/p/guile> now ranks
Guile as one of the least commented source code bases. There are many
good reasons why we ought to do better here, IMO.
WDYT?
> This patch makes a simple "guile examples/web/debug-sxml.scm" server go
> from serving 3215 reqs/s to 3830 reqs/s. (Using "ab -n 100000 -c100
> http://localhost:8080/" on the same machine to test; the machine is my
> laptop. By way of comparison, stable-2.0 does 3225 reqs/s on that
> benchmark.)
Nice!
Did you try a micro-benchmark that would ‘dynamic-wind’ repeatedly?
Thanks,
Ludo’.
next prev parent reply other threads:[~2012-03-06 17:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-03 16:25 The dynamic stack Andy Wingo
2012-03-06 17:20 ` Ludovic Courtès [this message]
2012-03-06 20:32 ` Andy Wingo
2012-03-07 6:05 ` Noah Lavine
2012-03-07 9:51 ` Andy Wingo
2012-03-07 23:09 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k42xabo2.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=guile-devel@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).