From: Mark H Weaver <mhw@netris.org>
To: ludo@gnu.org (Ludovic Courtès)
Cc: guile-devel@gnu.org
Subject: Re: [PATCH] Preserve keyword in 'syntax-rules' and 'define-syntax-rule'
Date: Wed, 10 Oct 2012 19:34:55 -0400 [thread overview]
Message-ID: <87k3uxj3z4.fsf@tines.lan> (raw)
In-Reply-To: <87pq4qoyao.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 10 Oct 2012 22:41:03 +0200")
ludo@gnu.org (Ludovic Courtès) writes:
> Mark H Weaver <mhw@netris.org> skribis:
>
>> Unfortunately, preserving the macro keyword breaks one of Oleg
>> Kiselyov's macros, namely 'ppat' in system/base/pmatch.scm:
>
> [...]
>
>> Oleg's macro uses '_' in the keyword position of the pattern, even
>> though '_' is in the literals list. Therefore, it fails to match
>> because 'ppat' does not match that literal.
>
> I would call it a bug in ‘ppat’. However, the real question is how
> frequent that “bug” is. If people have come to rely on the current
> behavior, then it may be more reasonable to stick to it.
I tend to agree that it's arguably a bug in 'ppat'. I could go either
way on this, so I'll leave it up to you and Andy.
>> Among other things,
>
> What were the other things? :-)
Well, anything that uses pmatch will fail. I'm not aware of any other
problems.
Mark
next prev parent reply other threads:[~2012-10-10 23:34 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-10-08 18:20 [PATCH] Preserve keyword in 'syntax-rules' and 'define-syntax-rule' Mark H Weaver
2012-10-09 21:34 ` Ludovic Courtès
2012-10-10 17:41 ` Mark H Weaver
2012-10-10 20:41 ` Ludovic Courtès
2012-10-10 23:34 ` Mark H Weaver [this message]
2012-10-11 2:02 ` Alex Shinn
2012-10-11 7:26 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k3uxj3z4.fsf@tines.lan \
--to=mhw@netris.org \
--cc=guile-devel@gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).