va_end for scm_list_n, scm_c_issue_deprecation_warning_fmt

va_end for scm_list_n, scm_c_issue_deprecation_warning_fmt

[Kevin Ryde]

[-- Attachment #1: Type: text/plain, Size: 251 bytes --]

FYI,
        * deprecation.c (scm_c_issue_deprecation_warning_fmt): Add va_end.
        * list.c (scm_list_n): Ditto.

I'm not aware of any systems where a missing va_end is harmful.  If
anyone knows one then this could be put in the 1.6 branch too.


[-- Attachment #2: deprecation.c.va_end.diff --]
[-- Type: text/plain, Size: 274 bytes --]

--- deprecation.c.~1.16.~	2003-04-07 08:05:06.000000000 +1000
+++ deprecation.c	2003-07-09 17:11:49.000000000 +1000
@@ -84,6 +84,7 @@
 
   va_start (ap, msg);
   vsnprintf (buf, 511, msg, ap);
+  va_end (ap);
   buf[511] = '\0';
   scm_c_issue_deprecation_warning (buf);
 }

[-- Attachment #3: list.c.va_end.diff --]
[-- Type: text/plain, Size: 231 bytes --]

--- list.c.~1.70.~	2003-04-28 07:51:21.000000000 +1000
+++ list.c	2003-07-09 17:16:25.000000000 +1000
@@ -94,6 +94,7 @@
       pos = SCM_CDRLOC (*pos);
       elt = va_arg (foo, SCM);
     }
+  va_end (foo);
   return answer;
 }
 

[-- Attachment #4: Type: text/plain, Size: 142 bytes --]

_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel

Re: va_end for scm_list_n, scm_c_issue_deprecation_warning_fmt

[Kevin Ryde]

I wrote:
>
>         * deprecation.c (scm_c_issue_deprecation_warning_fmt): Add va_end.
>         * list.c (scm_list_n): Ditto.
>
> I'm not aware of any systems where a missing va_end is harmful.  If
> anyone knows one then this could be put in the 1.6 branch too.

Actually, missing va_end is plain wrong, so I've applied this to
list.c in the 1.6 branch too, even if its absence hasn't been causing
an actual problem.


_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel