From mboxrd@z Thu Jan 1 00:00:00 1970 Path: main.gmane.org!not-for-mail From: Kevin Ryde Newsgroups: gmane.lisp.guile.devel Subject: Re: Forwarded patch for modular exponentiation support (GMP powm) Date: Sat, 14 Feb 2004 10:23:53 +1000 Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Message-ID: <87isiao6ee.fsf@zip.com.au> References: <87k73cng30.fsf@raven.i.defaultvalue.org> <874qtzsv3c.fsf@zip.com.au> <87llnah2hf.fsf@offby1.atm01.sea.blarg.net> <87hdxyctsa.fsf@zip.com.au> <87ad3qm76l.fsf@offby1.atm01.sea.blarg.net> <87vfmdfaga.fsf@zip.com.au> <87lln8lwue.fsf@offby1.atm01.sea.blarg.net> NNTP-Posting-Host: deer.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Trace: sea.gmane.org 1076718426 15062 80.91.224.253 (14 Feb 2004 00:27:06 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Sat, 14 Feb 2004 00:27:06 +0000 (UTC) Cc: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sat Feb 14 01:27:00 2004 Return-path: Original-Received: from monty-python.gnu.org ([199.232.76.173]) by deer.gmane.org with esmtp (Exim 3.35 #1 (Debian)) id 1Arne7-00056l-00 for ; Sat, 14 Feb 2004 01:27:00 +0100 Original-Received: from localhost ([127.0.0.1] helo=monty-python.gnu.org) by monty-python.gnu.org with esmtp (Exim 4.24) id 1Arndr-0002Tw-HH for guile-devel@m.gmane.org; Fri, 13 Feb 2004 19:26:43 -0500 Original-Received: from list by monty-python.gnu.org with tmda-scanned (Exim 4.24) id 1ArndP-0002ON-BW for guile-devel@gnu.org; Fri, 13 Feb 2004 19:26:15 -0500 Original-Received: from mail by monty-python.gnu.org with spam-scanned (Exim 4.24) id 1Arncq-0001yd-AG for guile-devel@gnu.org; Fri, 13 Feb 2004 19:26:11 -0500 Original-Received: from [61.8.0.84] (helo=mailout1.pacific.net.au) by monty-python.gnu.org with esmtp (Exim 4.24) id 1ArnbN-0001YI-SK for guile-devel@gnu.org; Fri, 13 Feb 2004 19:24:10 -0500 Original-Received: from mailproxy1.pacific.net.au (mailproxy1.pacific.net.au [61.8.0.86]) by mailout1.pacific.net.au (8.12.3/8.12.3/Debian-6.6) with ESMTP id i1E0O3LE003209; Sat, 14 Feb 2004 11:24:03 +1100 Original-Received: from localhost (ppp182.dyn249.pacific.net.au [203.143.249.182]) by mailproxy1.pacific.net.au (8.12.3/8.12.3/Debian-6.6) with ESMTP id i1E0O20H018283; Sat, 14 Feb 2004 11:24:03 +1100 Original-Received: from gg by localhost with local (Exim 3.36 #1 (Debian)) id 1Arnb9-0000OY-00; Sat, 14 Feb 2004 10:23:55 +1000 Original-To: Eric Hanchrow Mail-Copies-To: never In-Reply-To: <87lln8lwue.fsf@offby1.atm01.sea.blarg.net> (Eric Hanchrow's message of "Wed, 11 Feb 2004 20:56:25 -0800") User-Agent: Gnus/5.110002 (No Gnus v0.2) Emacs/21.3 (gnu/linux) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.2 Precedence: list List-Id: Developers list for Guile, the GNU extensibility library List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: main.gmane.org gmane.lisp.guile.devel:3373 X-Report-Spam: http://spam.gmane.org/gmane.lisp.guile.devel:3373 Eric Hanchrow writes: > > +coerce_to_big (SCM in, mpz_t out) > +{ > ... > + scm_wrong_type_arg ("modulo-expt", 1, in); I think there's another memory leak here. Eg. if k is an invalid type then n_tmp previously inited is not cleared. > + if (SCM_NFALSEP (scm_zero_p (m))) Probably don't need to call scm_zero_p for that, just "m==SCM_MAKINUM(0)" I think, since inexacts etc will be rejected by the coerce. _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://mail.gnu.org/mailman/listinfo/guile-devel