From: Neil Jerram <neil@ossau.uklinux.net>
Subject: Re: [PATCH] `try-module-autoload' and `current-reader'
Date: Thu, 19 Jan 2006 00:13:54 +0000 [thread overview]
Message-ID: <87irshhy65.fsf@ossau.uklinux.net> (raw)
In-Reply-To: <874q49yfvb.fsf@laas.fr> ( Ludovic Courtès's message of "Thu, 12 Jan 2006 10:06:48 +0100")
ludovic.courtes@laas.fr (Ludovic Courtès) writes:
> Hi,
>
> In `boot-9.scm', `try-module-autoload' should be using `load-module',
> and not `primitive-load', when loading a non-compiled module. The
> reasons are (i) non-autoloaded modules are loaded using `load-module'
> and (ii) `load-module' and `primitive-load' interact differently with
> the `current-reader' fluid.
>
> `load-module' uses R4RS `load' which does some framing on the value of
> `current-reader', setting it to `#f' (meaning: use the built-in `read')
> if no optional reader argument was provided. OTOH, `primitive-load'
> doesn't change the value of `current-reader', thus resulting in a
> different behavior.
Hmm; I think just adding (with-fluids ((current-reader #f)) ...)
around the (load-file ...) call would be better. Otherwise we would
be introducing two extra changes:
1. Starting a new stack (the start-stack form in R4RS's load). This
affects backtraces, and it is occasionally useful for a backtrace
to show that module X is being loaded because of code from module
Y.
2. Interpreting a file path beginning with "." as relative to the
current module's load filename.
What do you think?
Neil
_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/guile-devel
next prev parent reply other threads:[~2006-01-19 0:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-01-12 9:06 [PATCH] `try-module-autoload' and `current-reader' Ludovic Courtès
2006-01-19 0:13 ` Neil Jerram [this message]
2006-01-19 8:42 ` Ludovic Courtès
2006-01-21 8:46 ` Neil Jerram
2006-01-23 8:22 ` Ludovic Courtès
2006-01-26 19:25 ` Neil Jerram
2006-01-27 8:41 ` Ludovic Courtès
2006-02-04 15:54 ` Neil Jerram
2006-01-19 21:54 ` Kevin Ryde
2006-01-20 8:31 ` Ludovic Courtès
2006-01-20 20:47 ` Kevin Ryde
2006-01-21 8:29 ` Neil Jerram
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://www.gnu.org/software/guile/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87irshhy65.fsf@ossau.uklinux.net \
--to=neil@ossau.uklinux.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).