From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludovic.courtes@laas.fr (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] GC code cleanup #2 Date: Mon, 30 Jan 2006 10:14:37 +0100 Organization: LAAS-CNRS Message-ID: <87irs22i2q.fsf@laas.fr> References: <87vexjoibu.fsf@laas.fr> <873bk3ncb4.fsf_-_@laas.fr> NNTP-Posting-Host: main.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Transfer-Encoding: quoted-printable X-Trace: sea.gmane.org 1138612506 16772 80.91.229.2 (30 Jan 2006 09:15:06 GMT) X-Complaints-To: usenet@sea.gmane.org NNTP-Posting-Date: Mon, 30 Jan 2006 09:15:06 +0000 (UTC) Cc: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Jan 30 10:15:02 2006 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by ciao.gmane.org with esmtp (Exim 4.43) id 1F3V7c-0003tc-Uy for guile-devel@m.gmane.org; Mon, 30 Jan 2006 10:14:53 +0100 Original-Received: from localhost ([127.0.0.1] helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F3VAZ-0008C5-PZ for guile-devel@m.gmane.org; Mon, 30 Jan 2006 04:17:55 -0500 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1F3VAU-0008BO-KC for guile-devel@gnu.org; Mon, 30 Jan 2006 04:17:51 -0500 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1F3VAR-0008B6-LM for guile-devel@gnu.org; Mon, 30 Jan 2006 04:17:48 -0500 Original-Received: from [199.232.76.173] (helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1F3VAR-0008B3-Dg for guile-devel@gnu.org; Mon, 30 Jan 2006 04:17:47 -0500 Original-Received: from [140.93.0.15] (helo=laas.laas.fr) by monty-python.gnu.org with esmtps (TLS-1.0:DHE_RSA_AES_256_CBC_SHA:32) (Exim 4.52) id 1F3V8i-0003SN-CA for guile-devel@gnu.org; Mon, 30 Jan 2006 04:16:00 -0500 Original-Received: by laas.laas.fr (8.13.1/8.13.4) with SMTP id k0U9Ecso025344; Mon, 30 Jan 2006 10:14:40 +0100 (CET) Original-To: hanwen@xs4all.nl X-URL: http://www.laas.fr/~lcourtes/ X-Revolutionary-Date: 11 =?iso-8859-1?Q?Pluvi=F4se?= an 214 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEB1F5364 X-PGP-Key: http://www.laas.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: powerpc-unknown-linux-gnu Mail-Followup-To: hanwen@xs4all.nl, guile-devel@gnu.org In-Reply-To: <873bk3ncb4.fsf_-_@laas.fr> (Ludovic =?iso-8859-1?Q?Court=E8s?= =?iso-8859-1?Q?'s?= message of "Wed, 04 Jan 2006 18:16:31 +0100") User-Agent: Gnus/5.110004 (No Gnus v0.4) Emacs/21.4 (gnu/linux) X-Spam-Score: 0 () X-Scanned-By: MIMEDefang at CNRS-LAAS X-MIME-Autoconverted: from 8bit to quoted-printable by laas.laas.fr id k0U9Ecso025344 X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:5641 Archived-At: Hi, ludovic.courtes@laas.fr (Ludovic Court=E8s) writes: > 2006-01-04 Ludovic Court=E8s > > * libguile/gc-segment.c (scm_i_sweep_some_cards): Take a SWEEP_STATS > argument. Don't refer to SCM_GC_CELLS_COLLECTED and > SCM_CELLS_ALLOCATED. If SEG->FIRST_TIME, let CELLS_COLLECTED as zero. > Take into account SEG->SPAN when computing CELLS_SWEPT. > (scm_i_sweep_segment): Take one more argument, similarly. > (scm_i_sweep_all_segments): Likewise. > (scm_i_sweep_some_segments): Likewise. > (scm_i_adjust_min_yield): Change the way MIN_CELLS is computed: do not > refer to SCM_GC_CELLS_COLLECTED. > > * libguile/gc-freelist.c (scm_i_adjust_min_yield): Take one more > argument, an `scm_i_sweep_statistics' object. > Change the way DELTA is collected: don't take into account > SCM_GC_CELLS_COLLECTED_1, only SWEEP_STATS.COLLECTED. > =20 > * libguile/gc-malloc.c (scm_realloc): Pass an extra argument > to `scm_i_sweep_all_segments ()'. > =20 > * libguile/gc.c (gc_start_stats): Updated accordingly. > (gc_end_stats): Take an additional SWEEP_STATS argument. > Decrement SCM_CELLS_ALLOCATED after calls to `scm_i_sweep_* ()'. > (scm_gc_for_newcell): Updated callers of `scm_i_sweep_*'. > Decrement SCM_CELLS_ALLOCATED. > (scm_i_gc): Likewise. > =20 > * libguile/private-gc.h (scm_i_sweep_*): Updated function > prototypes accordingly. > (scm_t_sweep_statistics): New type. > (scm_i_sweep_statistics_init): New macro. > (scm_i_sweep_statistics_sum): New macro Can someone please review this patch? If it's acceptable, then I think it would be nice if it could go into the 1.8 branch as well. Thanks, Ludovic. _______________________________________________ Guile-devel mailing list Guile-devel@gnu.org http://lists.gnu.org/mailman/listinfo/guile-devel