From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: removing unused variables? Date: Mon, 21 Sep 2009 17:08:35 +0200 Message-ID: <87iqfcl4i4.fsf@gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: ger.gmane.org 1253545763 29353 80.91.229.12 (21 Sep 2009 15:09:23 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Mon, 21 Sep 2009 15:09:23 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Mon Sep 21 17:09:16 2009 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.50) id 1MpkVv-0001WC-Rr for guile-devel@m.gmane.org; Mon, 21 Sep 2009 17:09:16 +0200 Original-Received: from localhost ([127.0.0.1]:43435 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MpkVv-0005jc-B6 for guile-devel@m.gmane.org; Mon, 21 Sep 2009 11:09:15 -0400 Original-Received: from mailman by lists.gnu.org with tmda-scanned (Exim 4.43) id 1MpkVs-0005jJ-9j for guile-devel@gnu.org; Mon, 21 Sep 2009 11:09:12 -0400 Original-Received: from exim by lists.gnu.org with spam-scanned (Exim 4.43) id 1MpkVl-0005df-I3 for guile-devel@gnu.org; Mon, 21 Sep 2009 11:09:11 -0400 Original-Received: from [199.232.76.173] (port=35958 helo=monty-python.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1MpkVk-0005dO-JN for guile-devel@gnu.org; Mon, 21 Sep 2009 11:09:04 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:43242) by monty-python.gnu.org with esmtps (TLS-1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.60) (envelope-from ) id 1MpkVj-0004Xh-Tq for guile-devel@gnu.org; Mon, 21 Sep 2009 11:09:04 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.50) id 1MpkVi-0001S7-Ce for guile-devel@gnu.org; Mon, 21 Sep 2009 17:09:02 +0200 Original-Received: from laptop-147-210-128-170.labri.fr ([147.210.128.170]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 21 Sep 2009 17:09:02 +0200 Original-Received: from ludo by laptop-147-210-128-170.labri.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Mon, 21 Sep 2009 17:09:02 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 34 Original-X-Complaints-To: usenet@ger.gmane.org X-Gmane-NNTP-Posting-Host: laptop-147-210-128-170.labri.fr X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: Jour des =?iso-8859-1?Q?R=E9compenses?= de =?iso-8859-1?Q?l'Ann=E9e?= 217 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 821D 815D 902A 7EAB 5CEE D120 7FBA 3D4F EB1F 5364 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.1 (gnu/linux) Cancel-Lock: sha1:GnT0wM88P0GMKg/Oe75+SdTVxaM= X-detected-operating-system: by monty-python.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:9375 Archived-At: Hi, Andy Wingo writes: > ------------------------- module/language/assembly.scm ------------------------- > index 683da6c..95f8a2d 100644 > @@ -49,7 +49,7 @@ > (+ 1 *len-len* (string-length str))) > ((load-array ,bv) > (+ 1 *len-len* (bytevector-length bv))) > - ((load-program ,nargs ,nrest ,nlocs ,labels ,len ,meta . ,code) > + ((load-program _ _ _ _ ,len ,meta . _) > (+ 1 *program-header-len* len (if meta (1- (byte-length meta)) 0))) > ((,inst . _) (guard (>= (instruction-length inst) 0)) > (+ 1 (instruction-length inst))) > > > This is a bad change IMO. We should not contort our code to please some > mechanical idea of "good style". Oops, I actually agree with this one. Probably I should not have committed it before discussion, or at least in a separate, easily revertable commit. I apologize for not doing so. I can revert the offending parts, which are all ‘pmatch’ invocations. Would that be OK with you? That said, in many cases unused variables are a sign of sloppiness IMO, which was the reason I looked into it. However, having unused variables “for style” and unused variables introduced by macros makes it harder to identify “really unused” variables. Thanks, Ludo’.