From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?iso-8859-1?Q?Court=E8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Verify Size of Objcode Headers Date: Sun, 20 Jun 2010 23:22:35 +0200 Message-ID: <87iq5dwg9w.fsf@gnu.org> References: NNTP-Posting-Host: lo.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Trace: dough.gmane.org 1277069063 11871 80.91.229.12 (20 Jun 2010 21:24:23 GMT) X-Complaints-To: usenet@dough.gmane.org NNTP-Posting-Date: Sun, 20 Jun 2010 21:24:23 +0000 (UTC) To: guile-devel@gnu.org Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Sun Jun 20 23:24:22 2010 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([199.232.76.165]) by lo.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1OQRzd-0005oh-GW for guile-devel@m.gmane.org; Sun, 20 Jun 2010 23:24:21 +0200 Original-Received: from localhost ([127.0.0.1]:55910 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OQRzG-0000z8-PE for guile-devel@m.gmane.org; Sun, 20 Jun 2010 17:23:30 -0400 Original-Received: from [140.186.70.92] (port=44730 helo=eggs.gnu.org) by lists.gnu.org with esmtp (Exim 4.43) id 1OQRz9-0000n8-Iy for guile-devel@gnu.org; Sun, 20 Jun 2010 17:23:27 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.69) (envelope-from ) id 1OQRyZ-0001S8-8t for guile-devel@gnu.org; Sun, 20 Jun 2010 17:22:48 -0400 Original-Received: from lo.gmane.org ([80.91.229.12]:45633) by eggs.gnu.org with esmtp (Exim 4.69) (envelope-from ) id 1OQRyY-0001Rn-Te for guile-devel@gnu.org; Sun, 20 Jun 2010 17:22:47 -0400 Original-Received: from list by lo.gmane.org with local (Exim 4.69) (envelope-from ) id 1OQRyX-0005KR-IX for guile-devel@gnu.org; Sun, 20 Jun 2010 23:22:45 +0200 Original-Received: from acces.bordeaux.inria.fr ([193.50.110.5]) by main.gmane.org with esmtp (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 20 Jun 2010 23:22:45 +0200 Original-Received: from ludo by acces.bordeaux.inria.fr with local (Gmexim 0.1 (Debian)) id 1AlnuQ-0007hv-00 for ; Sun, 20 Jun 2010 23:22:45 +0200 X-Injected-Via-Gmane: http://gmane.org/ Original-Lines: 41 Original-X-Complaints-To: usenet@dough.gmane.org X-Gmane-NNTP-Posting-Host: acces.bordeaux.inria.fr X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 2 Messidor an 218 de la =?iso-8859-1?Q?R=E9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/23.2 (gnu/linux) Cancel-Lock: sha1:Y9q0iF+tLNhUH7nt8w3yTlkjZWg= X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 3) X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:10526 Archived-At: Hi Noah, Thanks for the patch! Noah Lavine writes: > + scm_t_uint8 dummy[] = { OBJCODE_HEADER(5,5) }; > + VERIFY_OBJCODE_HEADER_SIZE(dummy); I think that: verify (sizeof (dummy) == sizeof (struct scm_objcode)); would be enough (see below). Perhaps the ‘SCM_UNUSED’ attribute is needed here. > --- a/libguile/objcodes.h > +++ b/libguile/objcodes.h > @@ -21,6 +21,8 @@ > > #include > > +#include /* from Gnulib, in guile/lib */ This is a public header, so it can’t use private Gnulib headers. > +#define VERIFY_OBJCODE_HEADER_SIZE(header) verify(sizeof(header) \ > + == sizeof(struct > scm_objcode)) This is a private macro, so it would have to start with ‘SCM_I_’. But again, we can just avoid it altogether. Besides, make sure to follow the GNU coding style (info "(standards) Writing C"), such as leaving a white space before an opening bracket and after a closing bracket. Would you like to post an updated patch? Thanks, Ludo’.