Re: [Guile-commits] GNU Guile branch, wip-compiler, updated. v2.1.0-139-gf8a333e

Re: [Guile-commits] GNU Guile branch, wip-compiler, updated. v2.1.0-139-gf8a333e

[Ludovic Courtès]

Hi Noah,

Just a few superficial stylistic comments until I have something more
clever to say: ;-)

"Noah Lavine" <nlavine@haverford.edu> skribis:

>  (define default-environment
> -  `( (cons . ,(value-set-with-values 'cons))
> -     (car  . ,(value-set-with-values 'car))
> -     (cdr  . ,(value-set-with-values 'cdr))
> +  `( (cons . ,(value-set-with-values prim-cons))
> +     (car  . ,(value-set-with-values prim-car ))
> +     (cdr  . ,(value-set-with-values prim-cdr ))
>     ))

Please avoid trailing closing parenthesis.

Also, what about “vset” or just “set” instead of “value-set”?

> +              (set! (a-verify-exps ret)
> +                    (map (lambda (x) (rec ret x env)) args))
> +              ret))

Please privilege a functional style, as much as possible (in some cases
we lack the tools to do better, so that’s fine.)

> +(pass-if "value-set-can-be-anything?"
> +         (value-set-can-be-anything? anything))

In Emacs you can (put 'pass-if 'scheme-indent-function 1) to get the
“right” indentation.

Thanks,
Ludo’.

Re: [Guile-commits] GNU Guile branch, wip-compiler, updated. v2.1.0-139-gf8a333e

[Noah Lavine]

Hello,

Sorry it's been so long since my last reply. I've been somewhat busy
around the holidays, but I hope to work more soon.

> Also, what about “vset” or just “set” instead of “value-set”?

Yes, probably a good idea.

>> +              (set! (a-verify-exps ret)
>> +                    (map (lambda (x) (rec ret x env)) args))
>> +              ret))
>
> Please privilege a functional style, as much as possible (in some cases
> we lack the tools to do better, so that’s fine.)

I don't think there's a functional way to do this, although I could be
wrong. What I want to do is make a structure where the child tree
nodes are linked to their parents. I can't get the address of the
parent until after I allocate it, so I allocate it with an empty list
of children, then use its address to make the list of children that I
want.

Another approach would be to make the list of children before
allocating the parent, but then I would have to go back and fix up
their 'parent' pointers. So I think either way I'm stuck doing some
mutation.

>> +(pass-if "value-set-can-be-anything?"
>> +         (value-set-can-be-anything? anything))
>
> In Emacs you can (put 'pass-if 'scheme-indent-function 1) to get the
> “right” indentation.

Ah, thanks. Done.

Noah