From mboxrd@z Thu Jan 1 00:00:00 1970 Path: news.gmane.org!not-for-mail From: ludo@gnu.org (Ludovic =?utf-8?Q?Court=C3=A8s?=) Newsgroups: gmane.lisp.guile.devel Subject: Re: [PATCH] Add private port structure, and move iconv descriptors there Date: Wed, 27 Mar 2013 21:28:28 +0100 Message-ID: <87ip4cr3ir.fsf@gnu.org> References: <87vc9ij5z0.fsf@pobox.com> <87fw0l2yyk.fsf@gnu.org> <877gltxgrg.fsf_-_@tines.lan> <87y5e8stst.fsf@pobox.com> <87d2vdekws.fsf@tines.lan> <87d2uk62a0.fsf_-_@tines.lan> NNTP-Posting-Host: plane.gmane.org Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Trace: ger.gmane.org 1364416123 24844 80.91.229.3 (27 Mar 2013 20:28:43 GMT) X-Complaints-To: usenet@ger.gmane.org NNTP-Posting-Date: Wed, 27 Mar 2013 20:28:43 +0000 (UTC) Cc: Andy Wingo , guile-devel@gnu.org To: Mark H Weaver Original-X-From: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Wed Mar 27 21:29:10 2013 Return-path: Envelope-to: guile-devel@m.gmane.org Original-Received: from lists.gnu.org ([208.118.235.17]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1UKwy5-0007G9-3Q for guile-devel@m.gmane.org; Wed, 27 Mar 2013 21:29:09 +0100 Original-Received: from localhost ([::1]:49871 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKwxh-0003UO-35 for guile-devel@m.gmane.org; Wed, 27 Mar 2013 16:28:45 -0400 Original-Received: from eggs.gnu.org ([208.118.235.92]:58082) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKwxc-0003UJ-Cu for guile-devel@gnu.org; Wed, 27 Mar 2013 16:28:41 -0400 Original-Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1UKwxb-00022q-B9 for guile-devel@gnu.org; Wed, 27 Mar 2013 16:28:40 -0400 Original-Received: from [2a01:e0b:1:123:ca0a:a9ff:fe03:271e] (port=54701 helo=xanadu.aquilenet.fr) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1UKwxb-00020j-4d for guile-devel@gnu.org; Wed, 27 Mar 2013 16:28:39 -0400 Original-Received: from localhost (localhost [127.0.0.1]) by xanadu.aquilenet.fr (Postfix) with ESMTP id 78DD7CA2D; Wed, 27 Mar 2013 21:28:29 +0100 (CET) Original-Received: from xanadu.aquilenet.fr ([127.0.0.1]) by localhost (xanadu.aquilenet.fr [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id mbqLcvQKY+SD; Wed, 27 Mar 2013 21:28:29 +0100 (CET) Original-Received: from pluto (reverse-83.fdn.fr [80.67.176.83]) by xanadu.aquilenet.fr (Postfix) with ESMTPSA id D42C8CA21; Wed, 27 Mar 2013 21:28:28 +0100 (CET) X-URL: http://www.fdn.fr/~lcourtes/ X-Revolutionary-Date: 7 Germinal an 221 de la =?utf-8?Q?R=C3=A9volution?= X-PGP-Key-ID: 0xEA52ECF4 X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc X-PGP-Fingerprint: 83C4 F8E5 10A3 3B4C 5BEA D15D 77DD 95E2 EA52 ECF4 X-OS: x86_64-unknown-linux-gnu In-Reply-To: <87d2uk62a0.fsf_-_@tines.lan> (Mark H. Weaver's message of "Wed, 27 Mar 2013 16:00:55 -0400") User-Agent: Gnus/5.130005 (Ma Gnus v0.5) Emacs/24.2 (gnu/linux) X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6.x X-Received-From: 2a01:e0b:1:123:ca0a:a9ff:fe03:271e X-BeenThere: guile-devel@gnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "Developers list for Guile, the GNU extensibility library" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Original-Sender: guile-devel-bounces+guile-devel=m.gmane.org@gnu.org Xref: news.gmane.org gmane.lisp.guile.devel:16031 Archived-At: Hi! Mark H Weaver skribis: > Here's a patch to add a private port structure. I moved both input_cd > and output_cd there. I plan to create more patches on top of this very > soon (BOM handling, more efficient per-port read options, maybe better > EOF handling), so a prompt review would be very helpful. Looks good to me, and definitely an improvement. Nitpicking: > +struct scm_t_port_private; Please add a short comment above. > + struct scm_t_port_private *internal; > + void *reserved_for_future_use; > } scm_t_port; Likewise. > +enum scm_t_port_encoding_type { Likewise. Also, brace on the next line. I=E2=80=99d be tempted to remove =E2=80=98_t=E2=80=99 from the name since i= t=E2=80=99s a tag. > +struct scm_t_port_private Likewise. > + enum scm_t_port_encoding_type encoding_type; > + void *input_cd; > + void *output_cd; > +}; Ideally a comment saying what the fields represent. Thanks! Ludo=E2=80=99.