unofficial mirror of guile-devel@gnu.org 
 help / color / mirror / Atom feed
From: Marius Vollmer <mvo@zagadka.ping.de>
Cc: guile-devel@gnu.org, Han-Wen <hanwen@cs.uu.nl>
Subject: Re: [PATCH]: Cross building and Cygwin fixes.
Date: 07 Jul 2002 22:35:48 +0200	[thread overview]
Message-ID: <87hejb6ztn.fsf@zagadka.ping.de> (raw)
In-Reply-To: <87r8ikdbj6.fsf@peder.flower>

Jan Nieuwenhuizen <janneke@gnu.org> writes:

> Please let me know what needs to be done to get this into CVS.

Thanks!  I have applied it (with some changes, see below) to the
'unstable' branch.  It is too late for 1.6.

> +if test "$cross_compiling" = "yes"; then
> +  AC_MSG_CHECKING(guile for build)
> +  GUILE_FOR_BUILD="${GUILE_FOR_BUILD-guile}"
> +else
> +  GUILE_FOR_BUILD='$(top_builddir_absolute)/pre-inst-guile'

I changed this to just

    GUILE_FOR_BUILD='$(preinstguile)'

but did not change am/preinstguile.  This keeps the roles of the
'pre-inst-guile' separate from the 'guile-for-build'.  pre-inst-guile
is used during "make check" for example, and guile-for-build is used
for the doc snarfing.

> +fi   
> +AC_ARG_WITH(guile-for-build,
> +  [  --with-guile-for-build=CC  native guile [...]
                               ^^
> +test -n "$with_guile_for_build" && GUILE_FOR_BUILD="$with_cc_for_build"
                                                             ^^

"GUILE" instead of "CC", no?

> +2002-07-03  Jan Nieuwenhuizen  <janneke@gnu.org>
> +
> +	* pre-inst-guile (preinstguile): Initialize with
> +	$(GUILE_FOR_BUILD) configure parameter.

I didn't make this change, see above.  Instead, I defined
snarf2checkedtexi as

  GUILE="$(GUILE_FOR_BUILD)" $(top_srcdir)/scripts/snarf-check-and-output-texi

> -#ifdef HAVE_WINSOCK2_H
> +#if defined (HAVE_WINSOCK2_H) \
> +  && !(defined (__CYGWIN32__) || defined (__CYGWIN__))
>  #include <winsock2.h>
>  #endif

What is the reason for this change?  Wouldn't it be better to fix the
check for <winsock2.h> in configure.in?

_______________________________________________
Guile-devel mailing list
Guile-devel@gnu.org
http://mail.gnu.org/mailman/listinfo/guile-devel


  reply	other threads:[~2002-07-07 20:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-03 16:25 [PATCH]: Cross building and Cygwin fixes Jan Nieuwenhuizen
2002-07-07 20:35 ` Marius Vollmer [this message]
2002-07-08  9:04   ` Han-Wen Nienhuys
2002-07-08 18:12     ` Marius Vollmer
2002-07-08  9:52   ` Jan Nieuwenhuizen
2002-07-09 18:08     ` Marius Vollmer
2002-07-10  0:37       ` Jan Nieuwenhuizen
2002-07-10 19:34         ` Marius Vollmer
2002-07-10 19:52           ` Marius Vollmer
2002-07-10 20:02             ` Jan Nieuwenhuizen
  -- strict thread matches above, loose matches on Subject: below --
2002-07-03 17:06 Jan Nieuwenhuizen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://www.gnu.org/software/guile/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87hejb6ztn.fsf@zagadka.ping.de \
    --to=mvo@zagadka.ping.de \
    --cc=guile-devel@gnu.org \
    --cc=hanwen@cs.uu.nl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).